Skip to content

Proposal to fix provider - #3188

Closed
hannesa2 wants to merge 1 commit into
masterfrom
ProviderFix
Closed

Proposal to fix provider#3188
hannesa2 wants to merge 1 commit into
masterfrom
ProviderFix

Conversation

@hannesa2

Copy link
Copy Markdown
Contributor

It's a proposal to fix conflicting provider form logging lib owncloud/android-library#379
It simply accept the provider from ownCloud

@hannesa2hannesa2 changed the title Fix providerProposal to fix providerApr 6, 2021
@jesmrec

Copy link
Copy Markdown
Member

Thanks for the fix.

In the code review, take in account this: owncloud/android-library#379 (comment)
@theScrabi@abelgardep@JuancaG05

@abelgardep

Copy link
Copy Markdown
Contributor

Hi @hannesa2, this solution does not fix the problem completely. Yes, we can build the app now, but it crashes when we try to share the logs. Could you take a look? Thanks!

 Process: com.owncloud.android, PID: 29054
java.lang.IllegalArgumentException: Couldn't find meta-data for provider with authority com.owncloud.android.provider
at androidx.core.content.FileProvider.parsePathStrategy(FileProvider.java:606)
at androidx.core.content.FileProvider.getPathStrategy(FileProvider.java:579)
at androidx.core.content.FileProvider.getUriForFile(FileProvider.java:417)
at info.hannes.logcat.base.LogBaseFragment.sendLogContent(LogBaseFragment.kt:229)
at info.hannes.logcat.base.LogBaseFragment.onOptionsItemSelected(LogBaseFragment.kt:176)```

@jesmrecjesmrec added p3-medium Normal priority and removed Sprint labels May 7, 2021
@jesmrecjesmrec modified the milestones: 2.18-current, backlogMay 20, 2021
@jesmrec

Copy link
Copy Markdown
Member

@hannesa2 could you update this PR together with owncloud/android-library#379 (or this branch, more recent: https://github.com/owncloud/android-library/tree/optionalLiveLogging)

The idea is checking this asap over our newest master in order to merge it before moving the library to a new module.

Thanks a lot in advance

@hannesa2hannesa2 mentioned this pull request Jun 4, 2023
@JuancaG05JuancaG05 removed this from the backlog milestone May 3, 2024
@hannesa2hannesa2 closed this Jun 7, 2024
@hannesa2
hannesa2 deleted the ProviderFix branch June 7, 2024 06:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hannesa2@jesmrec@abelgardep@JuancaG05