Skip to content

[TECHNICAL] Upgrade min SDK to Android 7.0 (v24) - #4299

Merged
Aitorbp merged 5 commits into
masterfrom
technical/upgrade_min_sdk_to_android_7
Feb 20, 2024
Merged

[TECHNICAL] Upgrade min SDK to Android 7.0 (v24)#4299
Aitorbp merged 5 commits into
masterfrom
technical/upgrade_min_sdk_to_android_7

Conversation

@Aitorbp

@AitorbpAitorbp commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

Related Issues

App:#4230

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@AitorbpAitorbp self-assigned this Jan 26, 2024
@AitorbpAitorbp linked an issue Jan 26, 2024 that may be closed by this pull request
7 tasks
@Aitorbp
Aitorbpforce-pushed the technical/upgrade_min_sdk_to_android_7 branch from 69e1f9e to 5a22381CompareJanuary 26, 2024 13:43
@Aitorbp
Aitorbpforce-pushed the technical/upgrade_min_sdk_to_android_7 branch 2 times, most recently from 5a22381 to 14b5ab5CompareFebruary 15, 2024 08:20

@JuancaG05JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change here and ready to go! @Aitorbp

@JuancaG05JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely remove the ShareLinkToDialog.java class as well, since it is not used anymore

@Aitorbp
Aitorbpforce-pushed the technical/upgrade_min_sdk_to_android_7 branch 2 times, most recently from b29dcc9 to 453e3b4CompareFebruary 19, 2024 23:04

@JuancaG05JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec

Copy link
Copy Markdown
Member

Some basic checks performed: installation, not installation in Android 6 and, video preview and share sheet.

Everything OK from my side to move forward.

@Aitorbp
Aitorbpforce-pushed the technical/upgrade_min_sdk_to_android_7 branch from b77b5e9 to fd8767bCompareFebruary 20, 2024 11:30
@Aitorbp
Aitorbp merged commit 6518649 into masterFeb 20, 2024
@Aitorbp
Aitorbp deleted the technical/upgrade_min_sdk_to_android_7 branch February 20, 2024 12:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Upgrade min SDK to Android 7.0 (v24)

3 participants

@Aitorbp@jesmrec@JuancaG05