Add `promisc_on` to DLPI handle by mkeeter · Pull Request #5 · oxidecomputer/boot-image-tools

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

mkeeter · 2025-10-15T20:06:11Z

This is needed for Reverso snooping

adamlouis

works on reverso test on silver!

@mkeeter - are we clear to merge?

rmustacc · 2026-05-07T01:52:23Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

adamlouis · 2026-05-07T02:01:04Z

Why does reverso require us to turn on promiscuous mode for the boot server? How is this intersecting that work given this is normally used for booting helios?

@rmustacc - We are not turning it on for the bootserver - only using the dlpi module in facade to write the reverso loopback code.

See this branch: https://github.com/oxidecomputer/facade/compare/main...adamlouis/reverso

Can break this out if preferred!

rmustacc · 2026-05-07T02:14:30Z

Uh, this seems like a case where we should be using https://github.com/oxidecomputer/dlpi-sys/ versus trying to make a binary here into a dependent crate. I guess we're ultimately just adding bindings here, but since we have a real library crate we should use it long term.

rmustacc · 2026-05-07T03:21:18Z

 }
+
+ /// Enables promiscuous mode (rx only) on the DLPI handle
+ pub fn promisc_on(&mut self) -> Result<()> {


I think hard coding what promisc means if this is supposed to be a generic dlpi crate is a bit weird. This particular combination is a pretty bespoke need where as most stuff would traditionally use physical promisc. So maybe this should take an argument? If we need to land something as an interim to unblock stuff we can but it seems like honestly all this should go away in favor of libdlpi-sys? I found a4b3d2a as part of looking at the history here.

mkeeter · 2026-05-07T13:13:37Z

@mkeeter - are we clear to merge?

I have no recollection of this change, so will defer to Robert 😅

Add promisc_on to DLPI handle
bb92229

mkeeter requested a review from jclulow October 15, 2025 20:06

adamlouis approved these changes May 7, 2026
View reviewed changes