[fmt] match Omicron rust formatting for consistency + edition 2024 by zeeshanlakhani · Pull Request #183 · oxidecomputer/dendrite

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

zeeshanlakhani · 2026-01-14T04:43:05Z

My editor complains when using 2024 edition enhancements, even though the min version here is Rust 1.90.

This PR aligns us with Omicron's formatting style (and edition).

FelixMcFelix

This looks to generally condense things overall. I'm happy with it since it matches the decisions we've made in other repos.

I did attempt to verify the change on my Macbook to some extent:

kyle@Mac dendrite % git diff
kyle@Mac dendrite % git diff origin/zl/match-omicron-fmt-edition --stat
asic/src/chaos/mod.rs | 10 ++++++++--
asic/src/chaos/table.rs | 5 ++++-
asic/src/lib.rs | 5 ++++-
asic/src/softnpu/mgmt.rs | 7 +++++--
asic/src/softnpu/mod.rs | 30 ++++++++++++++++++++++--------
asic/src/softnpu/table.rs | 6 +++++-
asic/src/tofino_asic/bf_wrapper.rs | 23 ++++++++++++++++++-----
asic/src/tofino_asic/link_fsm.rs | 6 +++++-
asic/src/tofino_asic/mcast.rs | 16 +++++++++++++---
asic/src/tofino_asic/mod.rs | 18 +++++++++++++++---
asic/src/tofino_asic/ports.rs | 41 ++++++++++++++++++++++++++++++++---------
asic/src/tofino_asic/qsfp.rs | 30 +++++++++++++++++++++++++-----
asic/src/tofino_asic/serdes.rs | 27 +++++++++++++++++++++------
asic/src/tofino_asic/table.rs | 43 ++++++++++++++++++++++++++++++++-----------
asic/src/tofino_common/mod.rs | 7 ++++++-
asic/src/tofino_stub/mcast.rs | 4 +++-
asic/src/tofino_stub/mod.rs | 5 ++++-
asic/src/tofino_stub/ports.rs | 22 ++++++++++++++++++----
pcap/src/lib.rs | 10 +++++++---
19 files changed, 247 insertions(+), 68 deletions(-)
kyle@Mac dendrite % cargo fmt --check
Error writing files: failed to resolve mod `genpd`: /Users/kyle/gits/dendrite/asic/src/tofino_asic/genpd.rs does not exist
Error writing files: failed to resolve mod `ffi`: /Users/kyle/gits/dendrite/pcap/src/ffi.rs does not exist
kyle@Mac dendrite %

So I have some divergence, but that lines up with some of the modules just not playing well on this platform. The diff itself does just look like, as reported, cargo fmt has bailed on those modules for me.

zeeshanlakhani · 2026-01-15T04:28:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

…edition

FelixMcFelix · 2026-01-17T13:31:54Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.

I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

zeeshanlakhani · 2026-01-18T06:38:47Z

@FelixMcFelix I can't ignore those generated files, and it seems to be OSX only, as they can't build.
I don't think this has to be fixed here; it will have always been the case, I'd think? So long as there's an issue tracking then I think this PR does what it set out to.

Yeah, its' essentially wait for some nightly features to come around for fmt.

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50)

This wires up the softnpu ASIC backend to support multicast end-to-end by translating DPD's sidecar.p4 table operations into sidecar-lite.p4's simplified P4 pipeline. ## AsicMulticastOps We replace the stubbed AsicMulticastOps implementation (which returned "OperationUnsupported" for group creation and port addition with in-memory group tracking via McGroupData, following the tofino_stub pattern. Group membership is used by the table translation layer to build port bitmaps for sidecar-lite's Replicate extern. Ports >= 128 are rejected at add time to match sidecar-lite's 128-bit bitmap width. ## Table translation (asic/src/softnpu/table.rs) We map sidecar.p4 table names to sidecar-lite equivalents and translate action parameters where the designs differ for emulation. ## Fix update semantics We fix an issue with stale in-memory sources after update with absent source list(s). `modify_group_external` wrote back `new.sources.or(existing)` to the in-memory record while `update_external_tables` in the same call canonicalized `new.sources` directly to rewrite the P4 source-filter entries. A `None` update therefore cleared the P4 table but left a stale `Some([...])` in memory. All multicast action arms are gated with #[cfg(feature = "multicast")]. ## References and Deps - [softnpu #183](oxidecomputer/softnpu#183) - [propolis #1093](oxidecomputer/propolis#1093) - [p4rs #240](oxidecomputer/p4#240) - [sidecar-lite #152](oxidecomputer/sidecar-lite#152) - tokio: 1.50 (due to softnpu) - oxide-tokio-rt: 0.1.3 (following-up from tokio's move to 1.50) - bump oxide-tokio-rt to 0.1.4, tokio to 1.52.1 (matching Omicron)

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

[fmt] match Omicron rust formatting for consistency + edition 2024
312b5c7

zeeshanlakhani requested review from FelixMcFelix and Nieuwejaar January 14, 2026 04:44

FelixMcFelix approved these changes Jan 14, 2026
View reviewed changes

zeeshanlakhani added 4 commits January 15, 2026 04:42

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
eea1d1f
…edition

[post-merge] fmt
09c985e

Merge remote-tracking branch 'origin/main' into zl/match-omicron-fmt-…
a10425c
…edition

[post-merge] fmt
a7d38dd

zeeshanlakhani merged commit 0fa03e2 into mainJan 20, 2026
5 checks passed

zeeshanlakhani deleted the zl/match-omicron-fmt-edition branch January 20, 2026 04:36

Uh oh!

Conversation

zeeshanlakhani commented Jan 14, 2026

Uh oh!

FelixMcFelix left a comment

Choose a reason for hiding this comment

Uh oh!

zeeshanlakhani commented Jan 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FelixMcFelix commented Jan 17, 2026

Uh oh!

zeeshanlakhani commented Jan 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

zeeshanlakhani commented Jan 14, 2026

Uh oh!

FelixMcFelix left a comment

Choose a reason for hiding this comment

Uh oh!

zeeshanlakhani commented Jan 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FelixMcFelix commented Jan 17, 2026

Uh oh!

zeeshanlakhani commented Jan 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

zeeshanlakhani commented Jan 14, 2026

Uh oh!

FelixMcFelix left a comment

Choose a reason for hiding this comment

Uh oh!

zeeshanlakhani commented Jan 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FelixMcFelix commented Jan 17, 2026

Uh oh!

zeeshanlakhani commented Jan 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

zeeshanlakhani commented Jan 14, 2026

Uh oh!

FelixMcFelix left a comment

Choose a reason for hiding this comment

Uh oh!

zeeshanlakhani commented Jan 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FelixMcFelix commented Jan 17, 2026

zeeshanlakhani commented Jan 15, 2026•
edited
Loading

zeeshanlakhani commented Jan 15, 2026•
edited
Loading

zeeshanlakhani commented Jan 15, 2026•
edited
Loading

zeeshanlakhani commented Jan 15, 2026•
edited
Loading

zeeshanlakhani commented Jan 15, 2026•
edited
Loading