Skip to content

Fix pump statuses in pre-auth workflow documentation - #2

Open
jpwenzel wants to merge 3 commits into
mainfrom
fix-documentation-pre-auth-pump-statuses
Open

Fix pump statuses in pre-auth workflow documentation#2
jpwenzel wants to merge 3 commits into
mainfrom
fix-documentation-pre-auth-pump-statuses

Conversation

@jpwenzel

Copy link
Copy Markdown
Member

Fix for #1

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Part 3 walkthrough to correct the documented pump-status transitions for the Pre-Auth workflow (Issue #1), aligning the flow diagram and examples with the intended Pre-Auth “locked idle” behavior.

Changes:

  • Corrects Pre-Auth flow overview pump status sequence (locked idle → free → in-use → locked → locked).
  • Updates Pre-Auth command handling snippets (UNLOCKPUMP, LOCKPUMP, LOCKEDPUMP) to reflect corrected statuses.
  • Adjusts Pre-Auth full examples to match the corrected status transitions (including post-CLEAR and cancellation paths).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadwalkthrough/part-3.md
* PUMP 3 locked
* PUMP 3 free
```

CopilotAIApr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section says that after a successful UNLOCKPUMP the client should publish * PUMP 3 free, but Part 4’s “Pre-Auth Flow with TRANSACTIONINFO” example currently publishes * PUMP 1 locked immediately after UNLOCKPUMP (walkthrough/part-4.md:204-207). Please align the docs (either update Part 4’s example/status or add a clarifying note here about the correct status transition).

Suggested change
> **Clarification:** Immediately after a successful `UNLOCKPUMP`, the pump should be published as `free` so the customer can begin fueling. If you see an example elsewhere in the walkthrough showing `locked` immediately after `UNLOCKPUMP`, treat that as outdated — `locked` is not the correct post-unlock status transition here.

Copilot uses AI. Check for mistakes.
Comment threadwalkthrough/part-3.md
Comment on lines 369 to +371
Server: S2 CLEAR 3 e2f74ef5-f427-4ae6-bdd3-70a96709992f e2f74ef5-f427-4ae6-bdd3-70a96709992f pace
Client: S2 OK
Client: * PUMP 3 free
Client: * PUMP 3 locked

CopilotAIApr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Pre-Auth full example, after CLEAR the pump status is updated to locked, but Step 6 describes CLEAR as freeing the pump and shows * PUMP 3 free on success (walkthrough/part-3.md:249-274). Please reconcile these two descriptions (e.g., document that Post-Pay returns to free while Pre-Auth returns to locked idle, and adjust the Step 6 guidance accordingly).

Copilot uses AI. Check for mistakes.
Comment threadwalkthrough/part-3.md Outdated

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadwalkthrough/part-3.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jpwenzel