Pylint? #119

Open
Open
Pylint?#119

Description

@davet2001
davet2001
opened on Dec 16, 2021

@padelt How do you feel about pylint?

Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

To give an idea, these are the current errors:

 pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
      Skip to content

      Pylint? #119

      Open
      Open
      Pylint?#119

      Description

      @davet2001
      davet2001
      opened on Dec 16, 2021

      @padelt How do you feel about pylint?

      Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

      To give an idea, these are the current errors:

       pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          Pylint? #119

          Open
          Open
          Pylint?#119

          Description

          @davet2001
          davet2001
          opened on Dec 16, 2021

          @padelt How do you feel about pylint?

          Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

          To give an idea, these are the current errors:

           pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              Pylint? #119

              Open
              Open
              Pylint?#119

              Description

              @davet2001
              davet2001
              opened on Dec 16, 2021

              @padelt How do you feel about pylint?

              Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

              To give an idea, these are the current errors:

               pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  Pylint? #119

                  Open
                  Open
                  Pylint?#119

                  Description

                  @davet2001
                  davet2001
                  opened on Dec 16, 2021

                  @padelt How do you feel about pylint?

                  Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

                  To give an idea, these are the current errors:

                   pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

                  Activity

                  Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      Pylint? #119

                      Open
                      Open
                      Pylint?#119

                      Description

                      @davet2001
                      davet2001
                      opened on Dec 16, 2021

                      @padelt How do you feel about pylint?

                      Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

                      To give an idea, these are the current errors:

                       pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

                      Activity

                      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          Pylint? #119

                          Open
                          Open
                          Pylint?#119

                          Description

                          @davet2001
                          davet2001
                          opened on Dec 16, 2021

                          @padelt How do you feel about pylint?

                          Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

                          To give an idea, these are the current errors:

                           pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

                          Activity

                          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              Pylint? #119

                              Open
                              Open
                              Pylint?#119

                              Description

                              @davet2001
                              davet2001
                              opened on Dec 16, 2021

                              @padelt How do you feel about pylint?

                              Could be a code improvement? Probably a dedicated PR with no functional change, just formatting/renaming. All tests should pass before and after.

                              To give an idea, these are the current errors:

                               pylint temperusb/
************* Module temperusb
temperusb/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module temperusb.snmp
temperusb/snmp.py:5:1: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:35:0: C0301: Line too long (103/100) (line-too-long)
temperusb/snmp.py:45:0: C0301: Line too long (127/100) (line-too-long)
temperusb/snmp.py:57:91: C0303: Trailing whitespace (trailing-whitespace)
temperusb/snmp.py:79:0: C0301: Line too long (109/100) (line-too-long)
temperusb/snmp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/snmp.py:14:0: E0401: Unable to import 'snmp_passpersist' (import-error)
temperusb/snmp.py:20:23: C0103: Argument name "fd" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:24:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:27:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:27:4: R0201: Method could be a function (no-self-use)
temperusb/snmp.py:24:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:33:8: C0103: Attribute name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:41:16: C0103: Attribute name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:30:0: C0115: Missing class docstring (missing-class-docstring)
temperusb/snmp.py:31:23: C0103: Argument name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:46:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:43:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:44:23: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:45:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:46:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:47:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:53:18: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:56:23: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:56:16: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:57:42: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:75:19: W0703: Catching too general exception Exception (broad-except)
temperusb/snmp.py:74:40: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:75:12: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:76:38: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/snmp.py:30:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/snmp.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/snmp.py:87:4: C0103: Variable name "pp" doesn't conform to snake_case naming style (invalid-name)
temperusb/snmp.py:15:0: W0611: Unused TemperDevice imported from temperusb.temper (unused-import)
************* Module temperusb.temper
temperusb/temper.py:26:18: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:22: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:28: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:26:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:5: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:9: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:17: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:21: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:31: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:34: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:36: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:40: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:44: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:53: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:57: W1401: Anomalous backslash in string: '\s'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:67: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:70: W1401: Anomalous backslash in string: '\.'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:28:72: W1401: Anomalous backslash in string: '\d'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
temperusb/temper.py:145:0: C0301: Line too long (114/100) (line-too-long)
temperusb/temper.py:170:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens)
temperusb/temper.py:171:0: C0301: Line too long (111/100) (line-too-long)
temperusb/temper.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/temper.py:11:0: E0401: Unable to import 'usb' (import-error)
temperusb/temper.py:43:8: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:43:12: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:43:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:49:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)
temperusb/temper.py:78:0: R0205: Class 'TemperDevice' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:88:11: C0121: Comparison 'self._ports == None' should be 'self._ports is None' (singleton-comparison)
temperusb/temper.py:96:8: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:104:21: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:104:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:118:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
temperusb/temper.py:120:16: C0103: Variable name "f" doesn't conform to snake_case naming style (invalid-name)
temperusb/temper.py:118:20: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
temperusb/temper.py:150:37: W0613: Unused argument 'sensor' (unused-argument)
temperusb/temper.py:165:11: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPerV1.2', 'TEMPer1F_V1.3', 'TEMPERHUM1V1.3', 'TEMPer1F_H1_V1.4')" (consider-using-in)
temperusb/temper.py:170:53: C0321: More than one statement on a single line (multiple-statements)
temperusb/temper.py:260:12: W1201: Use lazy % formatting in logging functions (logging-not-lazy)
temperusb/temper.py:260:25: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:261:15: R1714: Consider merging these comparisons with "in" to "self._device.product in ('TEMPer1F_H1_V1.4', 'TEMPERHUM1V1.3')" (consider-using-in)
temperusb/temper.py:280:12: R1720: Unnecessary "else" after "raise" (no-else-raise)
temperusb/temper.py:281:16: W0707: Consider explicitly re-raising using the 'from' keyword (raise-missing-from)
temperusb/temper.py:288:30: W0622: Redefining built-in 'format' (redefined-builtin)
temperusb/temper.py:294:8: R1705: Unnecessary "elif" after "return" (no-else-return)
temperusb/temper.py:319:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:369:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:417:8: W0107: Unnecessary pass statement (unnecessary-pass)
temperusb/temper.py:420:0: R0205: Class 'TemperHandler' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
temperusb/temper.py:430:20: W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
temperusb/temper.py:430:20: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/temper.py:420:0: R0903: Too few public methods (1/2) (too-few-public-methods)
temperusb/temper.py:12:0: C0411: standard import "import os" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:13:0: C0411: standard import "import re" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:14:0: C0411: standard import "import logging" should be placed before "import usb" (wrong-import-order)
temperusb/temper.py:15:0: C0411: standard import "import struct" should be placed before "import usb" (wrong-import-order)
************* Module temperusb.cli
temperusb/cli.py:1:0: C0114: Missing module docstring (missing-module-docstring)
temperusb/cli.py:9:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: C0116: Missing function or method docstring (missing-function-docstring)
temperusb/cli.py:32:0: R0914: Too many local variables (21/15) (too-many-locals)
temperusb/cli.py:38:4: C0103: Variable name "th" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:41:14: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:58:15: C0103: Variable name "v" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:59:12: C0103: Variable name "c" doesn't conform to snake_case naming style (invalid-name)
temperusb/cli.py:62:12: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:78:26: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:86:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:92:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:88:32: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:96:16: W0702: No exception type(s) specified (bare-except)
temperusb/cli.py:95:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:101:21: C0209: Formatting a regular string which could be a f-string (consider-using-f-string)
temperusb/cli.py:32:0: R0912: Too many branches (18/12) (too-many-branches)
temperusb/cli.py:32:0: R0915: Too many statements (53/50) (too-many-statements)

                              Activity

                              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions