Uh oh!
There was an error while loading. Please reload this page.
Add endpoint service exception test util take 2 - #1379
Open
dummycode wants to merge 3 commits into
Open
Conversation
dummycodeforce-pushed
the
hh/endpoint-service-exception-test-util-2
branch
from
July 10, 2025 21:00
e398604 to
4654158Compare
added 2 commits
July 10, 2025 14:05
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement of #1366 which uses the newly introduced ancestor
BaseServiceExceptionfrom #1378 to consolidate some testing code.We wish to cleanly replace
assertThatServiceExceptionThrownBywithassertThatEndpointServiceExceptionThrownByin our service and this allows us to do that.