Uh oh!
There was an error while loading. Please reload this page.
Excavator: Render CircleCI file using template specified in .circleci/template.sh - #16
Merged
Merged
Conversation
svc-excavator-botforce-pushed
the
excavator/manage-circleci-oss
branch
2 times, most recently
from
November 26, 2018 14:03
6c00f6d to
ed8d996Comparesvc-excavator-botforce-pushed
the
excavator/manage-circleci-oss
branch
from
November 27, 2018 23:49
ed8d996 to
6865871Comparesvc-excavator-botforce-pushed
the
excavator/manage-circleci-oss
branch
from
November 28, 2018 11:51
6865871 to
b1b9cccCompareiamdanfox
approved these changes
Nov 29, 2018
carterkozak pushed a commit
that referenced
this pull request
Mar 9, 2022
Uses a simple condition rather than a switch statement After: `javap -c -p ./tracing/build/classes/java/main/com/palantir/tracing/Tracer.class` ``` private static boolean shouldObserve(com.palantir.tracing.Observability); Code: 0: aload_0 1: getstatic #10 // Field com/palantir/tracing/Observability.SAMPLE:Lcom/palantir/tracing/Observability; 4: if_acmpeq 25 7: aload_0 8: getstatic #11 // Field com/palantir/tracing/Observability.UNDECIDED:Lcom/palantir/tracing/Observability; 11: if_acmpne 29 14: getstatic #12 // Field sampler:Lcom/palantir/tracing/TraceSampler; 17: invokeinterface #13, 1 // InterfaceMethod com/palantir/tracing/TraceSampler.sample:()Z 22: ifeq 29 25: iconst_1 26: goto 30 29: iconst_0 30: ireturn ``` Before: `javap -c -p ./tracing/build/classes/java/main/com/palantir/tracing/Tracer.class` ``` private static boolean shouldObserve(com.palantir.tracing.Observability); Code: 0: getstatic #10 // Field com/palantir/tracing/Tracer$1.$SwitchMap$com$palantir$tracing$Observability:[I 3: aload_0 4: invokevirtual #11 // Method com/palantir/tracing/Observability.ordinal:()I 7: iaload 8: tableswitch { // 1 to 3 1: 36 2: 38 3: 40 default: 49 } 36: iconst_1 37: ireturn 38: iconst_0 39: ireturn 40: getstatic #12 // Field sampler:Lcom/palantir/tracing/TraceSampler; 43: invokeinterface #13, 1 // InterfaceMethod com/palantir/tracing/TraceSampler.sample:()Z 48: ireturn 49: new #14 // class com/palantir/logsafe/exceptions/SafeIllegalArgumentException 52: dup 53: ldc #15 // String Unknown observability 55: iconst_1 56: anewarray #16 // class com/palantir/logsafe/Arg 59: dup 60: iconst_0 61: ldc #17 // String observability 63: aload_0 64: invokestatic #18 // Method com/palantir/logsafe/SafeArg.of:(Ljava/lang/String;Ljava/lang/Object;)Lcom/palantir/logsafe/SafeArg; 67: aastore 68: invokespecial #19 // Method com/palantir/logsafe/exceptions/SafeIllegalArgumentException."<init>":(Ljava/lang/String;[Lcom/palantir/logsafe/Arg;)V 71: athrow ```
carterkozak pushed a commit
that referenced
this pull request
Mar 9, 2022
Uses a simple condition rather than a switch statement After: `javap -c -p ./tracing/build/classes/java/main/com/palantir/tracing/Tracer.class` ``` private static boolean shouldObserve(com.palantir.tracing.Observability); Code: 0: aload_0 1: getstatic #10 // Field com/palantir/tracing/Observability.SAMPLE:Lcom/palantir/tracing/Observability; 4: if_acmpeq 25 7: aload_0 8: getstatic #11 // Field com/palantir/tracing/Observability.UNDECIDED:Lcom/palantir/tracing/Observability; 11: if_acmpne 29 14: getstatic #12 // Field sampler:Lcom/palantir/tracing/TraceSampler; 17: invokeinterface #13, 1 // InterfaceMethod com/palantir/tracing/TraceSampler.sample:()Z 22: ifeq 29 25: iconst_1 26: goto 30 29: iconst_0 30: ireturn ``` Before: `javap -c -p ./tracing/build/classes/java/main/com/palantir/tracing/Tracer.class` ``` private static boolean shouldObserve(com.palantir.tracing.Observability); Code: 0: getstatic #10 // Field com/palantir/tracing/Tracer$1.$SwitchMap$com$palantir$tracing$Observability:[I 3: aload_0 4: invokevirtual #11 // Method com/palantir/tracing/Observability.ordinal:()I 7: iaload 8: tableswitch { // 1 to 3 1: 36 2: 38 3: 40 default: 49 } 36: iconst_1 37: ireturn 38: iconst_0 39: ireturn 40: getstatic #12 // Field sampler:Lcom/palantir/tracing/TraceSampler; 43: invokeinterface #13, 1 // InterfaceMethod com/palantir/tracing/TraceSampler.sample:()Z 48: ireturn 49: new #14 // class com/palantir/logsafe/exceptions/SafeIllegalArgumentException 52: dup 53: ldc #15 // String Unknown observability 55: iconst_1 56: anewarray #16 // class com/palantir/logsafe/Arg 59: dup 60: iconst_0 61: ldc #17 // String observability 63: aload_0 64: invokestatic #18 // Method com/palantir/logsafe/SafeArg.of:(Ljava/lang/String;Ljava/lang/Object;)Lcom/palantir/logsafe/SafeArg; 67: aastore 68: invokespecial #19 // Method com/palantir/logsafe/exceptions/SafeIllegalArgumentException."<init>":(Ljava/lang/String;[Lcom/palantir/logsafe/Arg;)V 71: athrow ``` Benchmarks show improvement within variance: Benchmarks AFTER: ``` Benchmark (observability) Mode Cnt Score Error Units TracingBenchmark.traceWithSingleSpan SAMPLE avgt 3 533.719 ± 164.796 ns/op TracingBenchmark.traceWithSingleSpan DO_NOT_SAMPLE avgt 3 100.138 ± 35.819 ns/op TracingBenchmark.traceWithSingleSpan UNDECIDED avgt 3 122.807 ± 64.274 ns/op ``` Benchmarks BEFORE: ``` Benchmark (observability) Mode Cnt Score Error Units TracingBenchmark.traceWithSingleSpan SAMPLE avgt 3 522.865 ± 65.310 ns/op TracingBenchmark.traceWithSingleSpan DO_NOT_SAMPLE avgt 3 112.647 ± 48.826 ns/op TracingBenchmark.traceWithSingleSpan UNDECIDED avgt 3 118.643 ± 6.733 ns/op ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the excavator/manage-circleci-oss check.
{runtimeCheckDesc}
To enable or disable this check, please contact the maintainers of Excavator.