Skip to content

[improvement] Revert adding spans to all wrapped executor tasks - #89

Merged
bulldozer-bot[bot] merged 1 commit into
palantir:developfrom
diogoholanda:dholanda/revert-adding-spans-to-all-tasks
Mar 7, 2019
Merged

[improvement] Revert adding spans to all wrapped executor tasks#89
bulldozer-bot[bot] merged 1 commit into
palantir:developfrom
diogoholanda:dholanda/revert-adding-spans-to-all-tasks

Conversation

@diogoholanda

@diogoholandadiogoholanda commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

Before this PR

In #71, all wrapped executor tasks had spans added by default. This was pretty noisy for tasks that were already doing their own wrapping.

After this PR

If wrapping is not explicitly requested, it is not done

@diogoholanda
diogoholanda requested a review from a team as a code ownerMarch 7, 2019 15:38
@diogoholanda

diogoholanda commented Mar 7, 2019

Copy link
Copy Markdown
ContributorAuthor

@dansanduleac@bavardage@pkoenig10
I guess I was too optimistic in the previous PR comments

@carterkozakcarterkozak changed the title [improvement] Rever adding spans to all wrapped executor tasks[improvement] Revert adding spans to all wrapped executor tasksMar 7, 2019
@dansanduleac

dansanduleac commented Mar 7, 2019

Copy link
Copy Markdown
Contributor

👍

@bulldozer-bot
bulldozer-botBot merged commit de00d8d into palantir:developMar 7, 2019
@diogoholanda
diogoholanda deleted the dholanda/revert-adding-spans-to-all-tasks branch March 7, 2019 15:58
@pkoenig10pkoenig10 mentioned this pull request Mar 27, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merge when ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diogoholanda@dansanduleac