Uh oh!
There was an error while loading. Please reload this page.
Add FAQ entry about edit() returning immediately - #3780
Open
kdeldycke wants to merge 1 commit into
Open
Conversation
kdeldyckeforce-pushed
the
spawned-editor-faq
branch
from
August 19, 2026 05:40
1efd23c to
9cd2758Comparekdeldyckeforce-pushed
the
spawned-editor-faq
branch
from
August 19, 2026 05:47
9cd2758 to
e03ce61Compare5 tasks
kdeldyckeforce-pushed
the
spawned-editor-faq
branch
from
August 27, 2026 14:31
e03ce61 to
a06df1fCompareRowlando13
commented
Aug 28, 2026
Member
@kdeldycke still 2 comments on this |
kdeldycke
commented
Aug 28, 2026
CollaboratorAuthor
Ah? Where? Maybe you left them on your side in a pending review but did not submit them, which is why I don't see them. Happened to me last time: your GitHub review comments are not public until you submit the whole review. |
davidism
approved these changes
Aug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Rowlando13
commented
Aug 28, 2026
Member
That was it. |
kdeldyckeforce-pushed
the
spawned-editor-faq
branch
from
August 28, 2026 21:50
a06df1f to
ce57b87Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explain why some editors are returning immediately and does not respect the contract of the
edit()utility.Also added a warning admonition to the
edit()docstring itself so developers relying on it get informed about the limitations.Closes#2582.