Improve Travis / tox setup + coverage by blueyed · Pull Request #851 · pallets/click

blueyed · 2017-09-19T22:49:35Z

Mainly inspired by using pytest directly in tox, for easy test selection
etc.

Mainly inspired by using pytest directly in tox, for easy test selection etc.

blueyed · 2017-09-26T18:57:46Z

Added coverage reports via codecov, which can be seen at https://codecov.io/gh/pallets/click/branch/improve-travis-tox.

This hopefully works around `complex/complex/commands/__init__.py` and `termui/termui.py` showing up in `examples` (at the root).

blueyed · 2017-09-28T21:14:13Z

@untitaker @axu2
Can you take a look, please?

blueyed · 2017-09-28T21:15:00Z

Also please authorize/install codecov on https://codecov.io/gh/pallets/click/.

untitaker · 2017-10-01T19:20:54Z

I wouldn't include codecov, particularly its notification settings are extremely buggy in my experience. I feel like it's more maintenance effort than it brings insight

…

On Thu, Sep 28, 2017 at 02:14:18PM -0700, Daniel Hahler wrote: @untitaker @axu2 Can you take a look, please? -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #851 (comment)

blueyed · 2017-10-06T19:38:29Z

@untitaker
What do you mean by "extremely buggy"?
What I am seeing sometimes is multiple comments, also only one should be there and edited.

maintenance effort

Do you mean that you have or want to delete the duplicated comments then?

If this is the issue you mean it might be solvalble by @codecov just fixing it in the end.. ;)

From my point of view codecov provides a lot of valuable insights.

ThiefMaster · 2017-10-06T19:41:13Z

IMO even just a single codecov comment on every PR is somewhat annoying. I like getting notifications from GitHub for new PRs and comments since that's convenient to see if there's anything to comment on, a PR to review, etc. But codecov comments? I'm tempted to overcome my laziness and configure my email filter to send the notifications about them straight to the trash folder. But that aside, IMO these comments are more noise than adding useful comment.

blueyed · 2017-10-06T19:53:41Z

@ThiefMaster
The recommended way is to install codecov's GitHub integration, where you would not see comments in your emails (AFAIK): https://github.com/integration/codecov.
Anyone with admin rights here could try it already.

Otherwise you could also just block the bot user (https://github.com/codecov-io), and be done with it I guess.

blueyed · 2017-10-06T19:54:13Z

Especially for PRs codecov's reporting is valuable, since it will tell you if coverage drops and if the diff is covered etc.

untitaker · 2017-10-06T21:50:27Z

If codecov were about to "just fix" anything they would have done that a long time ago.

…

On 6 October 2017 21:38:40 GMT+02:00, Daniel Hahler ***@***.***> wrote: @untitaker What do you mean by "extremely buggy"? What I am seeing sometimes is multiple comments, also only one should be there and edited. > maintenance effort Do you mean that you have or want to delete the duplicated comments then? If this is the issue you mean it might be solvalble by @codecov just fixing it in the end.. ;) >From my point of view codecov provides a lot of valuable insights. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #851 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

blueyed · 2017-10-06T22:09:40Z

@untitaker
It is still the best service for it, isn't it? coveralls is much worse and there is no other.

untitaker · 2017-10-06T22:10:51Z

Hence my suggestion to not have any such service.

…

On 7 October 2017 00:09:43 GMT+02:00, Daniel Hahler ***@***.***> wrote: @untitaker It is still the best service for it, isn't it? coveralls is much worse and there is no other. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #851 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

blueyed · 2017-10-06T22:11:53Z

What about the benefit to see if a PR covers its diff?

blueyed · 2017-10-06T22:13:47Z

And even in general, I think you can grasp a lot of useful info from https://codecov.io/gh/pallets/click/tree/improve-travis-tox/click already.

untitaker · 2017-10-06T22:17:16Z

I never disputed that the information provided by the service would be useful. But for that it would have to work properly, and that just has not been my experience at all. Flaky reports and/or random build failures because their weird CLI tool was unable to contact S3 or whatever. Bot comments are a non-starter, way too spammy,

…

On 7 October 2017 00:13:51 GMT+02:00, Daniel Hahler ***@***.***> wrote: And even in general, I think you can grasp a lot of useful info from https://codecov.io/gh/pallets/click/tree/improve-travis-tox/click already. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #851 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

untitaker · 2017-10-06T22:19:37Z

Ah, I see you used travis-retry for that purpose, fair enough. I guess we can merge this and also immediately block the bot org-wide. That should do it.

…

On 7 October 2017 00:13:51 GMT+02:00, Daniel Hahler ***@***.***> wrote: And even in general, I think you can grasp a lot of useful info from https://codecov.io/gh/pallets/click/tree/improve-travis-tox/click already. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #851 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

blueyed · 2017-10-06T23:06:40Z

@untitaker
Thanks.

blueyed · 2017-10-06T23:08:16Z

btw: it might be better to use pytest-cov here, since it would also track subprocess automatically - not sure if that is used in tests?!

untitaker · 2017-10-10T19:45:37Z

Thanks! Codecov seems to be already activated.

blueyed force-pushed the improve-travis-tox branch from d0aad44 to cef19ebCompare September 19, 2017 22:58

blueyed added 2 commits September 20, 2017 01:00

Improve Travis / tox setup
2087bc9
Mainly inspired by using pytest directly in tox, for easy test selection etc.

Travis: use lightweight containers (sudo=false)
c3b7066

blueyed force-pushed the improve-travis-tox branch from cef19eb to c3b7066Compare September 19, 2017 23:00

blueyed changed the title ~~Improve Travis / tox setup~~Improve Travis / tox setup + coverageSep 26, 2017

coverage/codecov integration
b61c167

blueyed force-pushed the improve-travis-tox branch from 16b780d to b61c167Compare September 26, 2017 19:56

blueyed added 2 commits September 26, 2017 22:44

include TEST_EXTRA as codecov flag
6c4eed1

codecov: -X fix
9eb1be2
This hopefully works around `complex/complex/commands/__init__.py` and `termui/termui.py` showing up in `examples` (at the root).

untitaker merged commit b471d34 into pallets:masterOct 10, 2017

blueyed deleted the improve-travis-tox branch October 10, 2017 22:42

github-actionsBot locked as resolved and limited conversation to collaborators Nov 13, 2020

kdeldycke added this to the 7.0 milestone Aug 8, 2026

kdeldycke added the tests Click's own test suite and CI workflows label Aug 8, 2026

Uh oh!

Uh oh!

Conversation

blueyed commented Sep 19, 2017

Uh oh!

blueyed commented Sep 26, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueyed commented Sep 28, 2017

Uh oh!

blueyed commented Sep 28, 2017

Uh oh!

untitaker commented Oct 1, 2017 via email

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

ThiefMaster commented Oct 6, 2017

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

untitaker commented Oct 6, 2017 via email

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

untitaker commented Oct 6, 2017 via email

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

untitaker commented Oct 6, 2017 via email

Uh oh!

untitaker commented Oct 6, 2017 via email

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

blueyed commented Oct 6, 2017

Uh oh!

untitaker commented Oct 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

blueyed commented Sep 26, 2017•
edited
Loading