Uh oh!
There was an error while loading. Please reload this page.
Bump actions/upload-pages-artifact from 3 to 5 - #6
Conversation
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3 to 5. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v5) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues |
There was a problem hiding this comment.
Pull Request Overview
The upgrade to actions/upload-pages-artifact v5 is technically valid and meets automated quality standards, but it introduces a breaking change regarding hidden file handling. Version 4 and above no longer include dotfiles by default. This PR does not currently account for this change, meaning the .nojekyll file generated in the workflow will be omitted from the final artifact. This may cause GitHub Pages to incorrectly process the site as a Jekyll project. To maintain current behavior, an explicit input must be added to the action configuration.
About this PR
- The update to version 5 includes a breaking change from version 4 where dotfiles are excluded by default. The workflow explicitly creates a .nojekyll file to prevent GitHub Pages from processing the site with Jekyll; this file will now be excluded from the artifact unless the include-hidden-files input is set to true.
Test suggestions
- Verify the workflow successfully executes with the updated action version
- Verify that dotfiles (specifically .nojekyll) are included in the generated artifact to maintain current behavior
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the workflow successfully executes with the updated action version
2. Verify that dotfiles (specifically .nojekyll) are included in the generated artifact to maintain current behavior
TIP Improve review quality by adding custom instructionsTIP How was this review? Give us feedback
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v3 | ||
| uses: actions/upload-pages-artifact@v5 |
There was a problem hiding this comment.
🟡 MEDIUM RISK
Suggestion: Version 5 of this action excludes dotfiles by default. Since this workflow creates a .nojekyll file for deployment, consider adding include-hidden-files: true to the action inputs to maintain current behavior.
Bumps actions/upload-pages-artifact from 3 to 5.
Release notes
Sourced from actions/upload-pages-artifact's releases.
Commits
fc324d3Merge pull request #139 from Tom-van-Woudenberg/patch-1fe9d4b7Merge branch 'main' into patch-10ca1617Merge pull request #137 from jonchurch/include-hidden-files57f0e84Update action.yml4a90348v7 --> hash56f665aUpdate upload-artifact action to version 7f7615f5Addinclude-hidden-filesinput7b1f4a7Merge pull request #127 from heavymachinery/pin-sha4cc19c7Pinactions/upload-artifactto SHA2d163beMerge pull request #107 from KittyChiu/mainDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)