Uh oh!
There was an error while loading. Please reload this page.
Use PEP518 and Poetry instead requirements.txt and setuptools - #26
Open
henryx wants to merge 5 commits into
Open
Use PEP518 and Poetry instead requirements.txt and setuptools#26henryx wants to merge 5 commits into
henryx wants to merge 5 commits into
Conversation
ioggstream
commented
Apr 7, 2023
Contributor
Can you separate the poetry stuff from the rest? We need to investigate more before switching to poetry, since we had issues with it in the past. |
henryx
commented
Apr 7, 2023
Author
No, because although PEP518 allows you to use other backends, the pyproject.toml has been configured to use Poetry |
ioggstream
requested changes
Jan 29, 2024
ioggstream
left a comment
Contributor
There was a problem hiding this comment.
Can we split the pyproject.toml and the poetry stuff?
| "Operating System :: OS Independent", | ||
| ] | ||
| [tool.poetry.dependencies] | ||
| python = "^3.11" |
Contributor
There was a problem hiding this comment.
@ioggstream consider adding this information somewhere in the README.md
Consider that Python 3.8 already reached EOL: https://endoflife.date/python
| requires = ["poetry-core>=1.0.0"] | ||
| build-backend = "poetry.core.masonry.api" | ||
| [tool.poetry] |
There was a problem hiding this comment.
Wrong section? (a legacy one?)
looked weird and https://python-poetry.org/docs/basic-usage/ uses [project]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #25