This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143

Merged
gavofyork merged 16 commits into
masterfrom
gav-init-fixes
May 7, 2018
Merged

Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom
gav-init-fixes

Conversation

@gavofyork

@gavofyorkgavofyork commented May 2, 2018

Copy link
Copy Markdown
Member

No description provided.

@gavofyorkgavofyork added the A0-please_review Pull request needs code review. label May 2, 2018
@gavofyorkgavofyork changed the title Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier reviewed May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs Outdated
/// Compare two fractions.
pub trait CompareRationals {
/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;

@rphmeierrphmeierMay 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?

rphmeier
rphmeier reviewed May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs Outdated
}
// AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
// to overflow the stack.
Self::compare_rationals(d2, r2, d1, r1)

@rphmeierrphmeierMay 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.

@gavofyork
gavofyork merged commit 0647b3b into masterMay 7, 2018
@gavofyork
gavofyork deleted the gav-init-fixes branch May 7, 2018 13:25
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit to boolnetwork/substrate that referenced this pull request Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_reviewPull request needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixes and improvements for PoC-1 Testnet - #143
Merged
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
May 7, 2018
Merged
Fixes and improvements for PoC-1 Testnet#143
gavofyork merged 16 commits into
masterfrom 
gav-init-fixes
Conversation
@gavofyork
@gavofyorkgavofyork
commented
May 2, 2018

Copy link


Copy Markdown

Member
 No description provided. 
@gavofyorkgavofyork
added
the 
A0-please_review
Pull request needs code review.
label
May 2, 2018
@gavofyorkgavofyork
changed the title
Fix initialisations and add a test.Fixes and improvements for PoC-1 TestnetMay 5, 2018
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

/// Compare two fractions.
pub trait CompareRationals {
	/// Return `true` iff `n1 / d1 < n2 / d2`. `d1` and `d2` may not be zero.
	fn compare_rationals(n1: Self, d1: Self, n2: Self, d2: Self) -> bool;
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not a free function?
rphmeier
rphmeier
reviewed
May 7, 2018
View reviewed changes
Comment threadsubstrate/runtime/democracy/src/vote_threshold.rs
Outdated

 }
 // AUDIT: could be dangerous if no tail recursion optimisation as votes could be crafted
 // to overflow the stack.
 Self::compare_rationals(d2, r2, d1, r1)
@rphmeierrphmeierMay 7, 2018

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use a loop then? AFAIK Rust doesn't support TCO in many cases or perhaps at all and there have been no successful RFCs for guaranteed TCO, so it's better not to be at the mercy of the compiler.
@gavofyork
gavofyork
merged commit 0647b3b
into
masterMay 7, 2018
@gavofyork
gavofyork
deleted the

gav-init-fixes

branch
May 7, 2018 13:25
lamafab pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
@rphmeier
some erasure-coding tweaks (paritytech#143)
5c96f58
JoshOrndorff added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
@notlesh@JoshOrndorff
Add clippy and rustfmt to CI (paritytech#143)
f27b277
* Add clippy/rustfmt checks to CI
Add clippy check to CI
Apply uses correctly
Specify runs-on
Use checkout specified from check-prettier
Try specifying toolchain with clippy as components
Apply to correct action
Specify nightly without date
Use 'rustup component add clippy' instead of toolchain
Uses on steps
Typo
Specify rustfmt and clippy in rust-toolchain file
Try only rustfmt
Undo
Revert rust-toolchain file
Add --workspace arg to clippy
* rustup clippy in init.sh
* Introduce 'install toolchain' step for Clippy
* Add rustfmt check
Add rustfmt check
--
* Update .rustfmt.toml to remove license checking (for now)
* Enforce rustfmt rules on codebase
* Update Cargo.lock
* Resolve clippy complaints
* Apply rustfmt
* Appease clippy @ node/parachain/src/chain_spec.rs
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
* Prefer unwrap_or_else to unwrap_or
* Avoid borrowed-box
* Add a pre-commit hook for rustfmt/clippy using rusty-hook
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com>
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com>
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@gguoss
Stage/poc (paritytech#143)
6ac8fb3
* btcbridge CandidateTx and records withdraw cache
* Fix precision and initialization error
* Initialize balance of alice same with activation_per_share
* Tweak initial intention profile
* fix bug for withdraw in canonize, add no_withdrawal flag
* Can not unstake when still in frozen
* Fix some bug
* Tweak session_length and sessions_per_era
* Fix bug: Only candidate confirmed can create new proposal
* Fix unexpect deposit
* Tweak staking fees
* Fix bug: Add unexpect in Candidate to handle unexpect deposit
* Fix/match precision (paritytech#131)
* fix pending order precision
* add tests
* Update genesis_config
* Fix when candidate initialize
* Recover AccountMap to support btc register
* Update genesis BlockHeader
* Fix select utxo must balance > 0
* move best index set before deposit/withdraw in canonize
* Fix build error
* Modify > irr_block as >=
* Fix bug: Only candidate is not confirmed can modifi it status
* Fix btc transaction correlation
* Adjust PCX precision in session reward (paritytech#134)
* Fix/match precision (paritytech#132)
* fix pending order precision
* add tests
* add reserve last
* 1. Fix UTXOList bug (paritytech#136)
2. Update genesis_config irr_block from 0 to 2
* Remove String (paritytech#137)
* Reserve initial nomination (paritytech#138)
* Fix wasm build error
* Init nominees of initial intenions (paritytech#139)
* UTXO only store value > 0
* Init channel (paritytech#140)
* Init channel relationship
* Init genesis intention
* chance channel name (paritytech#141)
* fix fill fee (paritytech#142)
* Tweak parameters
liuchengxu pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
@atenjin
revert testnet version from 45 to 42 (paritytech#143)
c2e7f83
liuchengxu added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
@liuchengxu
Add some modifications for cirrus development (paritytech#143)
ff9c6f9
* Separate out subspace-primitives from subspace-runtime
* Introduce `NewFull` struct in subspace-node
Also expose the `service` module in public.
* Make subspace-node a library
helin6 pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
@dvc94ch
Rc5 (paritytech#143)
e6f3a82
* Update to rc6.
* Update runtime.
* Update node to rc6.
* Update client.
* Fix node.
* Add option to enable telemetry.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


1 more reviewer

@rphmeierrphmeierrphmeier approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@gavofyork@rphmeier