Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Contracts: expose charge_storage to chain_extension - #14712

Merged
paritytech-processbot[bot] merged 3 commits into
masterfrom
pg/add_charge_storage
Aug 17, 2023
Merged

Contracts: expose charge_storage to chain_extension#14712
paritytech-processbot[bot] merged 3 commits into
masterfrom
pg/add_charge_storage

Conversation

@pgherveou

Copy link
Copy Markdown
Contributor

No description provided.

@pgherveou
pgherveou requested a review from athei as a code ownerAugust 4, 2023 13:52
@pgherveou
pgherveou requested a review from a teamAugust 4, 2023 13:52
@pgherveoupgherveou added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 4, 2023

@atheiathei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to re-export Diff so that the type can be constructed. Best to do that from chain_exntension.

@pgherveoupgherveou added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit label Aug 5, 2023
@pgherveou
pgherveou requested a review from atheiAugust 5, 2023 15:37
@athei
athei requested a review from agryaznovAugust 6, 2023 19:13
@pgherveou

Copy link
Copy Markdown
ContributorAuthor

bot merge

@paritytech-processbot
paritytech-processbotBot merged commit 0cdf702 into masterAug 17, 2023
@paritytech-processbot
paritytech-processbotBot deleted the pg/add_charge_storage branch August 17, 2023 13:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_reviewPull request needs code review.B0-silentChanges should not be mentioned in any release notesC1-lowPR touches the given topic and has a low impact on builders.D3-trivial 🧸PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pgherveou@athei@agryaznov