Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Revert "chore: update libp2p to 0.52.1 (#14429)" - #14722

Merged
paritytech-processbot[bot] merged 7 commits into
masterfrom
revert-libp2p-0.52
Aug 16, 2023
Merged

Revert "chore: update libp2p to 0.52.1 (#14429)"#14722
paritytech-processbot[bot] merged 7 commits into
masterfrom
revert-libp2p-0.52

Conversation

@altonen

@altonenaltonen commented Aug 6, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This reverts commit d38d176.

polkadot companion: paritytech/polkadot#7583
cumulus companion: paritytech/cumulus#2975

@altonenaltonen added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 6, 2023
@altonen
altonen requested review from a team, alindima, sandreim and vstakhovAugust 6, 2023 11:38
This was referenced Aug 7, 2023
Merged
Merged
dmitry-markin
dmitry-markin approved these changes Aug 7, 2023
View reviewed changes

@dmitry-markindmitry-markin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it required due to V1Lazy stuff?

@dmitry-markin
dmitry-markin requested a review from kppAugust 7, 2023 08:57
vstakhov
vstakhov approved these changes Aug 7, 2023
View reviewed changes

@vstakhovvstakhov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like the sense of reverting updates, but it seems that 0.51 behaves more stable in terms of network connectivity (at least as we can see on Versi).

ggwpez
ggwpez reviewed Aug 7, 2023
View reviewed changes
Comment threadframe/support/Cargo.toml
@paritytech-ci
paritytech-ci requested a review from a teamAugust 7, 2023 11:01
@altonen

altonen commented Aug 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@dmitry-markin

It's due to DHT issues we're experiencing on Versi. I'll get back to this upgrade soon enough but in the mean time we have to revert because I don't know how long it's going to take to figure out the underlying issues and there are other important tasks as well.

@ggwpez
ggwpez removed the request for review from a teamAugust 8, 2023 11:39
@alexgghalexggh mentioned this pull request Aug 8, 2023
Draft
@rphmeier

rphmeier commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

@altonen

altonen commented Aug 15, 2023

Copy link
Copy Markdown
ContributorAuthor

This should be merged, no?

As far as we know, libp2p 0.52.1 is broken and should be taken out of master ASAP, right?

yeah, just missing one last review from cumulus companion

kpp
kpp approved these changes Aug 16, 2023
View reviewed changes
@paritytech-cicd-pr

paritytech-cicd-pr commented Aug 16, 2023

Copy link
Copy Markdown

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3397107

@bkchr

bkchr commented Aug 16, 2023

Copy link
Copy Markdown
Member

bot merge force

@paritytech-processbot
paritytech-processbotBot merged commit e53cf32 into masterAug 16, 2023
@paritytech-processbot
paritytech-processbotBot deleted the revert-libp2p-0.52 branch August 16, 2023 10:06
@altonenaltonen mentioned this pull request Aug 16, 2023
Closed
@mxinden

mxinden commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

Let me know in case you need any help debugging the v0.52.1 issues you are seeing.

@altonen

altonen commented Aug 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@mxinden cheers, I'll be in contact with you when I start working the upgrade again and if I can't figure out the issues.

Ank4n pushed a commit that referenced this pull request Aug 20, 2023
@altonen@Ank4n
Revert "chore: update libp2p to 0.52.1 (#14429)" (#14722)
7071c60
* Revert "chore: update libp2p to 0.52.1 (#14429)"
This reverts commit d38d176.
* Fix dependencies
* Update dependencies
* Update Cargo.lock
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alindimaalindimaAwaiting requested review from alindima
5 more reviewers
@ggwpezggwpezggwpez left review comments
@kppkppkpp approved these changes
@vstakhovvstakhovvstakhov approved these changes
@dmitry-markindmitry-markindmitry-markin approved these changes
@sandreimsandreimsandreim approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_reviewPull request needs code review.B0-silentChanges should not be mentioned in any release notesC1-lowPR touches the given topic and has a low impact on builders.D3-trivial 🧸PR contains trivial changes in a runtime directory that do not require an audit

Projects

Networking
Status: Done ✅

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@altonen@rphmeier@paritytech-cicd-pr@bkchr@mxinden@kpp@vstakhov@dmitry-markin@ggwpez@sandreim