Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Fixed consensus message garbage collection - #191

Merged
gavofyork merged 3 commits into
masterfrom
ark-import-fix
May 31, 2018
Merged

Fixed consensus message garbage collection#191
gavofyork merged 3 commits into
masterfrom
ark-import-fix

Conversation

@arkpar

Copy link
Copy Markdown
Member
  • Removed flaky garbage collection based on block import notification and fixed garbage collection logic.
  • Added a fix to prevent downloading block that is being imported from consensus.

Fixes#183

@arkpararkpar changed the title Ark import fixFixed consensus message garbage collectionMay 31, 2018
@arkpararkpar added the A0-please_review Pull request needs code review. label May 31, 2018
@arkpar
arkpar requested a review from rphmeierMay 31, 2018 14:34
Comment threadsubstrate/network/src/consensus.rs Outdated


#[test]
fn collects_garbage() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we place this in a submodule?

@gavofyork
gavofyork merged commit cba5d36 into masterMay 31, 2018
@gavofyork
gavofyork deleted the ark-import-fix branch May 31, 2018 16:17
@gavofyorkgavofyork mentioned this pull request May 31, 2018
gavofyork added a commit that referenced this pull request May 31, 2018
* Merge branch 'master' into gav-result-dispatch
* Fix merge.
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* Rebuild runtime
* Remove invalid value from chainspec (paritytech#68)
* service: use grandpa block import for locally sealed aura blocks (paritytech#85)
* bump version to v0.3.1
* Update lock file.
* limit number of transactions when building blocks (paritytech#91)
* Update to latest Substrate
* Bump to 0.3.2
* Actually bump.
* v0.3.2 (paritytech#98)
* bump substrate version
* fix polkadot-collator
* point to alexander-backports of substrate
* bump version
* cli: fix node shutdown (paritytech#100)
* update to latest substrate, change to v0.3.4
* update to latest substrate, bump version to 0.3.5
* v0.3.6
* try to build on every v0.3 commit and update alexander-backports
* bump to v0.3.7
* bump to 0.3.8
* Bump to 0.3.9: network and pruning improvements
* Bump to 0.3.10: reduce network bandwidth usage
* Use libp2p-kad 0.3.2 (paritytech#122)
* Bump libp2p-identify to 0.3.1 (paritytech#123)
* Bump to 0.3.12 (paritytech#127)
* Update Substrate again (paritytech#128)
* update substrate and bump version to v0.3.13
* bump version to v0.3.14: fix --reserved-nodes
* add a manually curated grandpa module (paritytech#136)
* updating v0.3 to use substrate v0.10 (paritytech#146)
* updating to latest substrate v0.10
* better handling of outer poll
* nit
* fix tests
* remove comment
* reduce indentation
* use self.poll
* bring oneshot into scope
* spaces
* wrap
* remove match
* wrap
* Update primitives/Cargo.toml
Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>
* Update runtime/wasm/Cargo.toml
Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>
* Update runtime/wasm/Cargo.toml
Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>
* Update test-parachains/adder/collator/src/main.rs
Co-Authored-By: gterzian <2792687+gterzian@users.noreply.github.com>
* indent
* add paranthese
* config: fix wrong ip for alexander bootnode (paritytech#161)
* fix curated-grandpa and rebuild wasm (paritytech#162)
* [v0.3] Integrates new gossip system into Polkadot (paritytech#166)
* new gossip validation in network
* integrate new gossip into service
* network: guard validation network future under exit signal (paritytech#168)
* bump version to v0.3.15: substrate v0.10
* [v0.3] update to substrate master (paritytech#175)
* update to substrate master
* fix test
* service: fix telemetry endpoints on alexander chainspec (paritytech#169) (paritytech#178)
* Update v0.3 to latest Substrate master (paritytech#177)
* update substrate v0.3 to latest master
* bump spec version
* update to latest master: remove fees module
* update runtime blobs
* bump version to 0.3.16
* replace sr25519 accountid with anysigner
* bump version to v0.3.17
* Some PoC-3 GRANDPA tweaks (paritytech#181)
* call on_finalise after triggering curated_grandpa change
* make grandpa rounds shorter for faster finalization
* use authorities when calculating duty roster (paritytech#185)
* [v0.3] Update to substrate master (paritytech#183)
* update to latest substrate master
* bump version to 0.3.18
* update to latest substrate master
* bump spec version
* update runtime wasm blobs
* remove current_offline_slash from chain spec
* update to substrate master: bump version to v0.3.19 (paritytech#188)
* update to substrate master: bump version to v0.3.19
libp2p network improvements
* network: replace NodeIndex with PeerId
* network: fix tests
* polkadot v0.3.20 (paritytech#190)
* update to substrate master: bump version to 0.3.20
* runtime: add offchain worker trait
* runtime: rebuild wasm blobs
* bump spec version (paritytech#191)
* Fix compilation
* Update version to 0.4.0
* Switch to use `polkadot-master` branch from substrate
* Remove unused struct
* Remove `grandpa::SyncedAuthorities` from `OnSessionChange`
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this pull request Apr 21, 2021
* Restore parachain spec/wasm generation
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Add ChainExtApi, chainext_asset
* Add chainext_certprofiles
* Initialize cert
* Rework
* Add rpc/src/chainx
* Add native and crosschain assets
* Correct initialization in xaccounts
* Best stroage
* Use best_storage as most
* refactor get_data
native_asset impl it
* refactor crosschain_asset
* Refactor a bit
* Nit
* Simplify use
* Combine native and crosschain assets
* Add AssetStakingRevocation
* Vanity
* Use datetime instead of block number
* Add registered_at in intention props
* Add intentions and broken nomination records
* Pass nomination records
* Derive marco
* compile error fix for chainxext rpc module
* Utilize AssetType::StakingRevocation
* Naming
* Unnecceary touch
* Nit
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Closeparitytech#191 * Update default ports same as v1.0
* Solve conversations in pr#318
* Nit
* Avoid needless clone
Co-authored-by: Liu-Cheng Xu <xuliuchengxlc@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_reviewPull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block generation halted

3 participants

@arkpar@rphmeier@gavofyork