Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Use create instead of open for export blocks - #356

Merged
arkpar merged 1 commit into
masterfrom
ser-create-instead-open
Jul 17, 2018
Merged

Use create instead of open for export blocks#356
arkpar merged 1 commit into
masterfrom
ser-create-instead-open

Conversation

@pepyakin

Copy link
Copy Markdown
Contributor

I think it is meant to use create instead of open, simply because it doesn't make sense to get Write trait obj from open.

@pepyakinpepyakin added the A0-please_review Pull request needs code review. label Jul 17, 2018
@pepyakin
pepyakin requested a review from arkparJuly 17, 2018 19:51
@gavofyorkgavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Jul 17, 2018
@arkpar
arkpar merged commit 3dbaa54 into masterJul 17, 2018
@arkpar
arkpar deleted the ser-create-instead-open branch July 17, 2018 20:52
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* impl reward
* typo
* more clean RewardAttestation trait
* reward by index
* address grumble
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* v0.9.5
* Update wasm
* Improve staking and bootstrap (paritytech#358)
* Only introduce bootstrap_ series in std
* Try update trustees on new era
Closeparitytech#355
* Don't update TrusteeIntentions if no staff changes.
Closeparitytech#356
* Update wasm
* Rebuild wasm
* Don't update params in genesis and sort trustees in bootstrap
* Rebuild wasm
* Closeparitytech#321
* Fix/update trustee (paritytech#360)
* If the new address is the same as the old one, not update
* Update genesis header info
* Add boot_nodes
* Merge only_grandpa
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Enable the log rotation for non-dev chain by default
* Rename to enable_console_log to make it more explicit that it's a switch
* .
* Try cache@v2
* Switch to new cache@v2 example
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A2-insubstantialPull request requires no code review (e.g., a sub-repository hash update).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pepyakin@gavofyork@arkpar