Uh oh!
There was an error while loading. Please reload this page.
feat(docker): refined Dockerfile - #456
Conversation
rphmeier
commented
Jul 30, 2018
cc @chevdor |
chevdor
commented
Jul 30, 2018
Thanks for the PR @Akagi201. |
chevdor
commented
Jul 31, 2018
Not sure we need the |
@chevdor I post this PR to let the docker build process be the same as the manually build process. I think it is important for consistency. When build manually, just run so the Dockerfile should be the same process. I have tested it and you may check it twice. |
chevdor
commented
Jul 31, 2018
What I am trying to say is that |
Akagi201
commented
Aug 1, 2018
I agree with two stage docker build. It is also good for isolating the source code and binary. And I wrote one for my own use. https://github.com/Akagi201/dockerfile/blob/master/polkadot/Dockerfile I am not sure the need for the |
chevdor
commented
Aug 1, 2018
What is the size of the image you get in the end with your 2 stages image? |
chevdor
commented
Aug 3, 2018
@Akagi201 Thanks again for this PR, I will close it as agreed since the scripts are definitely not required. |
…error Assert specific error for submitting the execution receipt to txpool
Refined the Dockerfile scripts.