Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

force BFT delay in consensus service, not in proposer logic - #477

Merged
arkpar merged 2 commits into
masterfrom
rh-delay-bft
Aug 2, 2018
Merged

force BFT delay in consensus service, not in proposer logic#477
arkpar merged 2 commits into
masterfrom
rh-delay-bft

Conversation

@rphmeier

Copy link
Copy Markdown
Contributor

No description provided.

@rphmeierrphmeier added the A0-please_review Pull request needs code review. label Aug 1, 2018
@rphmeier
rphmeier requested a review from gavofyorkAugust 1, 2018 15:00

@gavofyorkgavofyork left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable enough.

@arkpar
arkpar merged commit fb41402 into masterAug 2, 2018
@arkpar
arkpar deleted the rh-delay-bft branch August 2, 2018 15:01
arkpar pushed a commit that referenced this pull request Aug 2, 2018
* move forced delay to consensus service
* fiddle with logging
arkpar added a commit that referenced this pull request Aug 2, 2018
* v0.2.3
* Lower bft timeout
* force BFT delay in consensus service, not in proposer logic (#477)
* move forced delay to consensus service
* fiddle with logging
dvdplm added a commit that referenced this pull request Aug 5, 2018
* master:
Add Links to Tags and House Style (#413)
Add seed generation tests (#476)
Added commit hash to --version (#489)
use write_all instead of write (#488)
should be MAX_IMPORTING_BLOCKS (#486)
Use hex_literal in tests, use rustc-hex from crates (#481)
Lower bft timeout (#483)
force BFT delay in consensus service, not in proposer logic (#477)
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
liuchengxu added a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_reviewPull request needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rphmeier@gavofyork@arkpar