This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016

Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom
drewstone:drew-precompiles
Closed

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom
drewstone:drew-precompiles

Conversation

@drewstone

@drewstonedrewstone commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.

The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.

@drewstone

drewstone commented Sep 3, 2020

Copy link
Copy Markdown
ContributorAuthor

Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962

@drewstonedrewstone changed the title Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas reviewed Sep 3, 2020
View reviewed changes

@sorpaassorpaas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).

Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.

@bkchr

bkchr commented Sep 8, 2020

Copy link
Copy Markdown
Member

@drewstone any updates?

bkchr
bkchr reviewed Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml Outdated
@drewstone

drewstone commented Sep 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Welp, now I'm getting std errors trying to work around this...

@drewstone

drewstone commented Sep 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Alright all updated without changing wabt

@gnunicorngnunicorn added the A0-please_review Pull request needs code review. label Sep 9, 2020
@drewstonedrewstone mentioned this pull request Sep 10, 2020
Open
TheQuantumPhysicist
TheQuantumPhysicist reviewed Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs Outdated
NikVolf
NikVolf reviewed Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml Outdated
@drewstone

drewstone commented Sep 22, 2020

Copy link
Copy Markdown
ContributorAuthor

Just updated again, thanks @NikVolf for the suggestion!

@gnunicorn

gnunicorn commented Oct 1, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

As this touches evm, @sorpaas should sign off at least.

@gnunicorngnunicorn added A3-needsresolving A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. labels Oct 1, 2020
@sorpaas

sorpaas commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.

@drewstone

drewstone commented Oct 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Will get to this this week! Sorry for the delay @sorpaas

@drewstone

drewstone commented Oct 15, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@sorpaas I added the feature flags. Lmk what you think!

sorpaas
sorpaas reviewed Oct 15, 2020
View reviewed changes

@sorpaassorpaas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:

  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.

Comment threadframe/evm/src/precompiles.rs Outdated
drewstoneand others added 2 commits October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm suggested changes Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Comment on lines +290 to +301
impl Precompile for Blake2F {
fn execute(
input: &[u8],
target_gas: Option<usize>,
) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
let mut state = Blake2b::new(64);
state.update(&input);
let ret = state.finalize().as_bytes().to_vec();
Ok((ExitSucceed::Returned, ret, cost))
}
}

@dvdplmdvdplmNov 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.

@bkchr

bkchr commented Nov 24, 2020

Copy link
Copy Markdown
Member

Pallet EVM was removed, so this pr is not required in Substrate anymore.

@bkchrbkchr closed this Nov 24, 2020
@drewstonedrewstone mentioned this pull request Dec 12, 2020
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas
6 more reviewers
@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content

This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify - #7016
Closed
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Closed
Add precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verify#7016
drewstone wants to merge 5 commits into
paritytech:masterfrom 
drewstone:drew-precompiles
Conversation
@drewstone
@drewstonedrewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

Contributor
Adds some precompiles to the repo for functionality that may or may not exist on other blockchains but are useful nonetheless. These are not tested as I'm unsure how to test them yet but most of it has been migrated from openethereum and existing EIPs.
The modexp one in particular is unsure to be correct as IO between the rust openethereum client and the substrate implementation are a bit different. I'm unsure how to replicate certain IO operations so I opted to manually implement the input parsing.
@drewstone
drewstone
commented
Sep 3, 2020

Copy link


Copy Markdown

ContributorAuthor
Currently BLS precompile cannot be added until I find a no_std compatible repo for doing elilptic curve operations on the BLS381 curve. The repo here mentions adding this functionality but has not indicated it is completed: https://github.com/matter-labs/eip1962
@drewstonedrewstone
changed the title
Add precompiles: blake2f, modexp, bn128, ed25519verifyAdd precompiles for pallet_evm operators: blake2f, modexp, bn128, ed25519verifySep 3, 2020
sorpaas
sorpaas
reviewed
Sep 3, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. The testing error seems to be something unrelated (but we still need to figure out and fix it).
Only grumble is if we can add feature gates for the additional dependencies. Then we enable those feature gates by default for ease of testing.
@bkchr
bkchr
commented
Sep 8, 2020

Copy link


Copy Markdown

Member
@drewstone any updates?
bkchr
bkchr
reviewed
Sep 8, 2020
View reviewed changes
Comment threadbin/node/executor/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Welp, now I'm getting std errors trying to work around this...
@drewstone
drewstone
commented
Sep 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Alright all updated without changing wabt
@gnunicorngnunicorn
added
the 
A0-please_review
Pull request needs code review.
label
Sep 9, 2020
@drewstonedrewstone
mentioned this pull request
Sep 10, 2020

Open

TheQuantumPhysicist
TheQuantumPhysicist
reviewed
Sep 12, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs
Outdated

NikVolf
NikVolf
reviewed
Sep 21, 2020
View reviewed changes
Comment threadframe/evm/Cargo.toml
Outdated

@drewstone
drewstone
commented
Sep 22, 2020

Copy link


Copy Markdown

ContributorAuthor
Just updated again, thanks @NikVolf for the suggestion!
@gnunicorn
gnunicorn
commented
Oct 1, 2020•

edited

Loading

Copy link


Copy Markdown

Contributor
As this touches evm, @sorpaas should sign off at least.
@gnunicorngnunicorn
added

A3-needsresolving

A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
labels
Oct 1, 2020
@sorpaas
sorpaas
commented
Oct 1, 2020

Copy link


Copy Markdown

Contributor
Still hoping @drewstone can add the feature gates as requested in the last review! It's otherwise LGTM.
@drewstone
drewstone
commented
Oct 10, 2020

Copy link


Copy Markdown

ContributorAuthor
Will get to this this week! Sorry for the delay @sorpaas
@drewstone
drewstone
commented
Oct 15, 2020•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@sorpaas I added the feature flags. Lmk what you think!
sorpaas
sorpaas
reviewed
Oct 15, 2020
View reviewed changes
@sorpaassorpaas
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, but needs to:
  1. Check in the updated lock file.
  2. Fix line width CI.
  3. Fix the styling nits.
Comment threadframe/evm/src/precompiles.rs
Outdated

drewstoneand others
added 2 commits
October 16, 2020 20:26
@drewstone@sorpaas
Update frame/evm/src/precompiles.rs
f697596
Co-authored-by: Wei Tang <accounts@that.world>
@drewstone
Spacing
5c49f62
dvdplm
dvdplm
suggested changes
Nov 20, 2020
View reviewed changes
Comment threadframe/evm/src/precompiles.rs

Comment on lines

+290
 to 
+301

impl Precompile for Blake2F {
	fn execute(
 input: &[u8],
 target_gas: Option<usize>,
	) -> core::result::Result<(ExitSucceed, Vec<u8>, usize), ExitError> {
 let cost = ensure_linear_cost(target_gas, input.len(), 15, 3)?;
 let mut state = Blake2b::new(64);
 state.update(&input);
 let ret = state.finalize().as_bytes().to_vec();
 Ok((ExitSucceed::Returned, ret, cost))
	}
}
@dvdplmdvdplmNov 20, 2020

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be the EIP-152 precompile, but rather the full Blake2 hash function.
@bkchr
bkchr
commented
Nov 24, 2020

Copy link


Copy Markdown

Member
Pallet EVM was removed, so this pr is not required in Substrate anymore.
@bkchrbkchr
closed this
Nov 24, 2020
@drewstonedrewstone
mentioned this pull request
Dec 12, 2020
 Merged

Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@andresilvaandresilvaAwaiting requested review from andresilva
@kianenigmakianenigmaAwaiting requested review from kianenigma
@mxindenmxindenAwaiting requested review from mxinden
@shawntabrizishawntabriziAwaiting requested review from shawntabrizi
@tomusdrwtomusdrwAwaiting requested review from tomusdrw
@sorpaassorpaasAwaiting requested review from sorpaas

6 more reviewers

@gnunicorngnunicorngnunicorn left review comments
@pepyakinpepyakinpepyakin left review comments
@NikVolfNikVolfNikVolf left review comments
@bkchrbkchrbkchr left review comments
@TheQuantumPhysicistTheQuantumPhysicistTheQuantumPhysicist left review comments
@dvdplmdvdplmdvdplm requested changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

A0-please_reviewPull request needs code review.A5-stalePull request did not receive any updates in a long time. No review needed at this stage. Close it.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

9 participants

@drewstone@bkchr@gnunicorn@sorpaas@dvdplm@pepyakin@NikVolf@TheQuantumPhysicist@paritytech-ci