Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Migrate pallet-lottery to pallet attribute macro - #8762

Merged
5 commits merged into
paritytech:masterfrom
shaunxw:sw/migrate-pallet-lottery
May 12, 2021
Merged

Migrate pallet-lottery to pallet attribute macro#8762
5 commits merged into
paritytech:masterfrom
shaunxw:sw/migrate-pallet-lottery

Conversation

@shaunxw

@shaunxwshaunxw commented May 8, 2021

Copy link
Copy Markdown
Contributor

Part of #7882.

Converts the Lottery pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Lottery pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Lottery pallet.

@shawntabrizishawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 8, 2021
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
shawntabrizi
shawntabrizi reviewed May 8, 2021
View reviewed changes
Comment threadframe/lottery/src/lib.rs Outdated
@shaunxw

shaunxw commented May 9, 2021

Copy link
Copy Markdown
ContributorAuthor

I think DispatchResultWithPostInfo is also used in some merged migration PRs from me. Will make a PR and replace them with DispatchResult.

@shaunxwshaunxw mentioned this pull request May 9, 2021
Merged
@gui1117

gui1117 commented May 12, 2021

Copy link
Copy Markdown
Contributor

bot merge

@ghost

ghost commented May 12, 2021

Copy link
Copy Markdown

Trying merge.

@ghost
ghost merged commit 5be1f40 into paritytech:masterMay 12, 2021
@shaunxw
shaunxw deleted the sw/migrate-pallet-lottery branch May 12, 2021 20:37
nazar-pc pushed a commit to autonomys/substrate that referenced this pull request Aug 8, 2021
@shaunxw@nazar-pc
Migrate pallet-lottery to pallet attribute macro (paritytech#8762)
9421866
* Migrate pallet-lottery to pallet attribute macro.
* Fix metadata inconsistency.
* fix
* Use DispatchResult in call returns.
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@shawntabrizishawntabrizishawntabrizi approved these changes
@gui1117gui1117gui1117 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B0-silentChanges should not be mentioned in any release notesC1-lowPR touches the given topic and has a low impact on builders.D3-trivial 🧸PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaunxw@gui1117@shawntabrizi