DispatchError::Module is now a tuple variant in latest Substrate by jsdw · Pull Request #439 · paritytech/subxt

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

jsdw · 2022-02-07T15:17:12Z

Update the codegen to accomodate this change.

When nightly CI fails owing to a new substrate binary, this is hopefully the fix.

dvdplm · 2022-02-08T09:55:02Z

CI's angry because of outdated metadata?

jsdw · 2022-02-08T10:47:22Z

I'll see whether it succeeds now; I'm assuming it'll start passing when a new binary is built with the breaking changes in.

(although we haven't had nightly CI complain yet so maybe not just yet!)

ascjones · 2022-02-11T17:45:07Z

I need this 🙏

ascjones · 2022-02-14T09:30:07Z

 pub fn details(&self) -> Option<ErrorDetails> {
- if let Self::Module { index, error } = self {
- match (index, error) {
+ if let Self::Module (module_error) = self {


One downside of this is that this codegen is now not backwards compatible with older versions of substrate. Not sure what a nice solution to this is. Of course we can always detect whether it is the tuple variant of the old struct variant, but then that is not a nice solution :)

Mmm yeah; the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other. Perhaps that's worth doing though so that this passes CI now (and continues to pass when the change finally lands)?
Side note: I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas? I may have to look into that!

the only solution that comes to mind is doing a proper check for it in the metadata and conditionally outputting one or the other.
I agree, unfortunately that seems to be the only way to do this.
I'm wondering why the change hasn't made it to the binary that CI uses yet. Any ideas?
I thought it automatically uses a recent build from master? If that was working right it should be there. Unless something is being cached somewhere.

Asked in the CI/CD room. We rely on a binary made available at https://releases.parity.io/substrate/x86_64-debian:stretch/latest/substrate/substrate from a nightly job on substrate gitlab, but the binary is from a commit ~21 days old..

The nightly job could certainly build and run the latest binary from master, but doing so would slow down the regular CI a bunch I suspect, so it would keep failing (not sure how much caching would end up helping though), so I avoided it.

dvdplm · 2022-02-15T08:32:03Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

jsdw · 2022-02-15T09:57:50Z

@jsdw Do you want to do the conditional check on the metadata to stay backwards compatible in this PR? Otherwise I'd be inclined to merge this.

Lemme have a stab at backward compat :)

ascjones

LGTM

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

ModuleError is now a tuple variant
a95c77d

lexnv approved these changes Feb 7, 2022
View reviewed changes

lexnv mentioned this pull request Feb 7, 2022
Modify examples to work with latest substrate changes #440
Closed

ascjones approved these changes Feb 8, 2022
View reviewed changes

ascjones mentioned this pull request Feb 11, 2022
Upgrade dependencies, sync with latest contracts API paritytech/smart-bench#2
Merged

ascjones reviewed Feb 14, 2022
View reviewed changes

jsdw added 5 commits February 15, 2022 12:32

Merge branch 'master' into jsdw-module-error
b73bdcd

more robust pointer to DispatchError
61b8034

backward compat
c1d1ff8

clippy
2b76adb

cargo fmt
e3e0d41

ascjones reviewed Feb 15, 2022
View reviewed changes

Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated
Comment threadcodegen/src/api/errors.rs Outdated

jsdw added 2 commits February 15, 2022 15:53

abort_call_site and simplify path comparison
99ea75b

clippy
eec70a0

ascjones approved these changes Feb 15, 2022
View reviewed changes

jsdw merged commit cb9177a into masterFeb 15, 2022

jsdw deleted the jsdw-module-error branch February 15, 2022 16:15

Uh oh!

Conversation

jsdw commented Feb 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dvdplm commented Feb 8, 2022

Uh oh!

jsdw commented Feb 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ascjones commented Feb 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsdwFeb 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvdplm commented Feb 15, 2022

Uh oh!

jsdw commented Feb 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ascjones left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jsdw commented Feb 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dvdplm commented Feb 8, 2022

Uh oh!

jsdw commented Feb 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ascjones commented Feb 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsdwFeb 14, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dvdplm commented Feb 15, 2022

Uh oh!

jsdw commented Feb 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ascjones left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

jsdw commented Feb 7, 2022•
edited
Loading

jsdw commented Feb 8, 2022•
edited
Loading

jsdwFeb 14, 2022•
edited
Loading

jsdw commented Feb 7, 2022•
edited
Loading

jsdw commented Feb 8, 2022•
edited
Loading

jsdwFeb 14, 2022•
edited
Loading

jsdw commented Feb 7, 2022•
edited
Loading

jsdw commented Feb 8, 2022•
edited
Loading

jsdwFeb 14, 2022•
edited
Loading