Uh oh!
There was an error while loading. Please reload this page.
fix: convert int and double to string in otel body - #1544
fix: convert int and double to string in otel body#1544nikhilsinhaparseable wants to merge 2 commits into
Conversation
WalkthroughChanges to OpenTelemetry value serialization in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/otel/otel_utils.rs`:
- Around line 82-85: The IntValue arm in the conversion logic
(OtelValue::IntValue) is incorrectly pushing both a string and a numeric
serde_json::Number into json_array, producing duplicate entries; update the
OtelValue::IntValue handling so it only pushes the string representation
(Value::String(i.to_string())) to json_array to match the top-level IntValue
behavior and DoubleValue handling, leaving the rest of the function unchanged
and removing the serde_json::Number::from(*i) push.
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit