Uh oh!
There was an error while loading. Please reload this page.
exclude protected users from user count in home api - #1576
Conversation
WalkthroughThe PR modifies the user count calculation in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/prism/home/mod.rs`:
- Around line 162-166: The current logic computes user_count as number of
non-protected users but still uses user_added = user_count > 1, which
incorrectly requires two non-protected users; change the threshold to user_added
= user_count > 0 so a single non-protected user marks user_added. Update the
assignment of user_added in src/prism/home/mod.rs (references: users(),
tenant_id, DEFAULT_TENANT, user_count, user_added) and adjust the inline comment
to reflect "at least one non-protected user".
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit