Uh oh!
There was an error while loading. Please reload this page.
update Cargo.toml for release v2.6.0 - #1583
Conversation
WalkthroughBump package version to 2.6.0 and update parseable_ui asset metadata; tighten JSON compatibility check for Timestamp values to disallow numeric JSON numbers (accept strings only). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
…tection Arrow's JSON decoder with coerce_primitive(false) cannot decode a JSON number (e.g., 1773595502.7462175) into a Timestamp field. it expects a string like "2026-03-15T17:13:59Z" this fixes the rejection when two log sources send same field - one as timestamp other as float number
3bf1dc4There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/event/format/mod.rs`:
- Around line 437-440: The comment near the Value::Number match arm incorrectly
asserts Arrow's JSON decoder rejects numeric JSON for Timestamp fields; update
the comment in src/event/format/mod.rs next to the Value::Number => false and
surrounding match logic to either remove the Arrow-specific claim or explicitly
state this is a Parseable-specific restriction (not an Arrow limitation).
Preserve the intended behavior if keeping the restriction, but change the
wording to reference our Parseable policy (or delete the inaccurate Arrow
reference) so the comment no longer misattributes behavior to Arrow's JSON
decoder.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary by CodeRabbit
Chores
Bug Fixes