Skip to content

add quantile values to known field list - #1644

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:otel-metrics-known
May 6, 2026
Merged

add quantile values to known field list#1644
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:otel-metrics-known

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseablenikhilsinhaparseable commented May 6, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Extended OpenTelemetry metrics support to include quantile value fields for enhanced metrics collection.

@coderabbitai

coderabbitaiBot commented May 6, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2a4dcab4-8c77-4178-8971-388890fadcea

📥 Commits

Reviewing files that changed from the base of the PR and between 9de3883 and f35d3cd.

📒 Files selected for processing (1)
  • src/otel/metrics.rs

Walkthrough

The OTEL_METRICS_KNOWN_FIELD_LIST constant in src/otel/metrics.rs is extended from 34 to 36 elements, with two new quantile-related field names added: data_point_quantile_values_quantile and data_point_quantile_values_value.

Changes

Metrics Known Fields Extension

Layer / File(s)Summary
Constant Definition
src/otel/metrics.rs
Array type signature changes from [&str; 34] to [&str; 36], and two new field entries are appended: data_point_quantile_values_quantile and data_point_quantile_values_value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Bounces with delight
Two quantiles hop into the fray,
Thirty-four becomes thirty-six in a day!
Metrics constants now stand tall,
With values and quantiles answering the call. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Description check⚠️ WarningThe pull request description is entirely missing. The template requires a description explaining goals, rationale, and changes, plus verification checkboxes, but none were provided.Add a pull request description including the goal of this change, rationale for adding these fields, and complete the required verification checklist.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: adding quantile values to the known field list in the metrics module, which aligns with the code modification.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit 090feb9 into parseablehq:mainMay 6, 2026
12 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request May 7, 2026
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jun 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nikhilsinhaparseable@parmesant