minor migration update

[parmesant]

if mode is Prism, it will read all stream jsons once

Fixes #XXXX.

Description

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Bug Fixes

  • Stream metadata lookups now use a consistent updated request path across queries, stats, storage, and dashboard views.
  • Improved handling during migration-related workflows, helping metadata loading stay reliable in Prism mode.

• New Features

  • Made metadata utilities available through the public API for broader reuse.

[coderabbitai]

Walkthrough

Adds an is_migration: bool parameter to the Metastore trait's get_all_stream_jsons method and its ObjectStoreMetastore implementation. All existing call sites pass false. In migration_stream, a new Prism-mode block calls the method during migration. migrate_stream_metadata and setup_logstream_metadata are made public, and the metadata module gains public visibility.

Changes

is_migration Parameter Rollout

Layer / File(s)	Summary
Trait and implementation signature update src/metastore/metastore_traits.rs, src/metastore/metastores/object_store_metastore.rs	get_all_stream_jsons gains is_migration: bool in the trait; ObjectStoreMetastore accepts it as _is_migration: bool with no body changes.
Migration path and exported helpers src/migration/mod.rs, src/lib.rs	migration_stream adds a Prism-mode block that awaits get_all_stream_jsons; migrate_stream_metadata and setup_logstream_metadata become pub; metadata module becomes pub mod.
Call site updates src/enterprise/utils.rs, src/handlers/http/cluster/mod.rs, src/handlers/http/modal/query/querier_logstream.rs, src/prism/home/mod.rs, src/query/mod.rs, src/query/stream_schema_provider.rs, src/storage/object_storage.rs	All existing get_all_stream_jsons invocations updated to pass the new trailing false argument.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• parseablehq/parseable#1632: Touches setup_logstream_metadata logic and metastore JSON fetching around migration, overlapping with the visibility changes here.
• parseablehq/parseable#1704: Follows the same pattern of adding an is_migration boolean to a metastore JSON-fetch method (get_stream_json) and updating its callers.

Suggested reviewers

• nikhilsinhaparseable

🐇 A boolean flag, so small and so true,
Now travels through metastore calls old and new.
Migration or not? Just pass false, says the code,
While Prism mode hops down its own little road.
The rabbit approves — clean, tidy, and bright! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only states the main idea and leaves the required template sections, issue reference, and checklist items unfilled.	Fill out the description template with goal, rationale, key changes, issue reference if any, and mark relevant test/docs checkboxes.
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is generic and doesn't describe the specific Prism migration behavior change.	Rename it to mention that Prism mode now preloads all stream JSONs during migration.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/lib.rs (1)

35-35: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid exporting the entire metadata module.

pub mod metadata also exposes unrelated helpers like update_stats and load_daily_metrics, not just the metadata types. If external callers only need LogStreamMetadata/SchemaVersion, prefer selective pub use re-exports so those internals stay private.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/lib.rs` at line 35, The public module export in lib.rs is too broad
because pub mod metadata exposes unrelated helpers beyond the intended metadata
types. Change the library surface to re-export only the needed symbols from the
metadata module, such as LogStreamMetadata and SchemaVersion, and keep helper
functions like update_stats and load_daily_metrics private to the module.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/migration/mod.rs`:
- Around line 276-281: The Prism prefetch in fetch_or_create_stream_metadata()
is currently discarded, causing an extra metastore read per stream and
duplicating work during run_migration(). Update the Prism branch that calls
PARSEABLE.metastore.get_all_stream_jsons(...) so the returned stream metadata is
actually reused by the rest of fetch_or_create_stream_metadata() instead of
immediately reading again, and ensure the metadata path honors the prefetched
data across the subsequent flow.
---
Nitpick comments:
In `@src/lib.rs`:
- Line 35: The public module export in lib.rs is too broad because pub mod
metadata exposes unrelated helpers beyond the intended metadata types. Change
the library surface to re-export only the needed symbols from the metadata
module, such as LogStreamMetadata and SchemaVersion, and keep helper functions
like update_stats and load_daily_metrics private to the module.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 563c5597-81fc-42eb-a9da-5fc8b1b4726d

📥 Commits

Reviewing files that changed from the base of the PR and between c54b762 and 7f7aa48.

📒 Files selected for processing (11)

• src/enterprise/utils.rs
• src/handlers/http/cluster/mod.rs
• src/handlers/http/modal/query/querier_logstream.rs
• src/lib.rs
• src/metastore/metastore_traits.rs
• src/metastore/metastores/object_store_metastore.rs
• src/migration/mod.rs
• src/prism/home/mod.rs
• src/query/mod.rs
• src/query/stream_schema_provider.rs
• src/storage/object_storage.rs