Uh oh!
There was an error while loading. Please reload this page.
make concurrent object store calls configurable - #1736
Conversation
add env P_MAX_OBJECT_STORE_REQUESTS default to 1000 controls how many concurrent calls DF makes to object store also, add metric_name bloom filter for otel-metrics
WalkthroughThe PR makes object-store request limits configurable per backend, adds a bloom filter to the OTel ChangesConfigurable object-store request limits
OTel metric storage metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/parseable/streams.rs`:
- Around line 737-741: Correct the Bloom-filter explanation in the surrounding
comment: state that it can reject definite non-membership, while false positives
may still allow a row group containing no matching metric to be read. Do not
describe Bloom membership as exact or claim that every row group without the
metric is rejected.
In `@src/storage/azure_blob.rs`:
- Around line 132-139: Reject zero for max_object_store_requests in the CLI
argument definitions for src/storage/azure_blob.rs lines 132-139,
src/storage/gcs.rs lines 105-112, and src/storage/s3.rs lines 170-177. Update
each clap parser to enforce a minimum value of 1 using a NonZeroUsize parser or
equivalent custom validation, preserving the existing default and usize
configuration behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7e42cb77-0527-420d-be93-04c5f74e9e84
📒 Files selected for processing (6)
src/otel/metrics.rssrc/parseable/streams.rssrc/storage/azure_blob.rssrc/storage/gcs.rssrc/storage/mod.rssrc/storage/s3.rs
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
add env P_MAX_OBJECT_STORE_REQUESTS default to 1000
controls how many concurrent calls DF makes to object store
also, add metric_name bloom filter for otel-metrics
Summary by CodeRabbit
New Features
P_MAX_OBJECT_STORE_REQUESTSsetting, with a default limit of 1,000 requests.Bug Fixes