[Upstream][Retrieval] Unmerged PR#4 - add longest common prefix function - #6
Merged
Merged
Conversation
…along with longest common prefix of matching binaries. Very common when implementing auto-completion.
|
@adamark this one is also good and makes sense on function name. Would also add that this could use docs as a quick follow up if you're up for that. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR link
PR Description:
I changed the function name from the authors
prefix!tolongest_common_prefixas we should follow elixir best practices which would argue that bang! appended functions should be used to indicate that the function is unsafe and may raise and also should only be used when there is a "safer" function with the same name that won't raise (at least not intentionally). This best practice is also shared with ruby which is why I was compelled to change it.