feat: implements encoding of floating point numbers as float64 - #2
feat: implements encoding of floating point numbers as float64#2jacaetevha wants to merge 4 commits into
Conversation
jacaetevha
commented
Mar 7, 2020
This fails for negative doubles. Will fix that soon. |
patriksimek
commented
Mar 9, 2020
Hey, thanks for your contribution! I know it may sound weird, but may I ask you to avoid using helper functions and move everything into the One more thing - can you please retain the old code formatting? Thanks! |
jacaetevha
commented
Mar 9, 2020
I can reformat the code to use tabs instead of spaces. Would you be more comfortable with helper functions that are all |
…r functions (is_nan, is_negative_zero)
jacaetevha
commented
Mar 29, 2020
@patriksimek any thoughts on having |
patriksimek
commented
Apr 11, 2020
I don't see much value in splitting that into multiple functions. There's no code duplication and those helper functions itself have no value to anyone. That being said, I'd still prefer to have everything in one function. Thanks! |
I ported the the encoding of floats to float64 from https://github.com/feross/ieee754