perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

perf(client): batch large thread sync updates (upstream #5344) - #328

Merged
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344
Aug 5, 2026
Merged

perf(client): batch large thread sync updates (upstream #5344)#328
patroza merged 1 commit into
fork/candidatesfrom
import/upstream-pr-5344

Conversation

@patroza

Copy link
Copy Markdown
Owner

Imports open upstream PR pingdotgg/t3code#5344 as one provenance commit on fork/candidates.

Source SHA: 783fd023c69f7ebc9c0ae657ce124cce77d94587 (upstream commits b623dc23b + 783fd023c, squashed).

Imported behavior

  • reduceThreadStreamItems: a pure reducer that folds a batch of OrchestrationThreadStreamItems into one state and one persistable snapshot, preserving sequence dedup, completion markers, and deletion handling.
  • Stream.groupedWithin(64, 16ms) on the live thread subscription, so a burst of thread events publishes the SubscriptionRefonce instead of once per event. Web and mobile stop rebuilding large thread views for every streamed event.
  • eventBatchSize on EnvironmentThreadStateOptions, plus upstream's two regression tests: ordered single-publication bursts, and persisting a settled snapshot when a batch ends with a non-persistable turn start.

Local adaptations

  • Kept our httpSnapshotLoadAttempted guard around the HTTP snapshot fallback (upstream does not have it); the call now goes through applyItems([...]).
  • Restored setDeleted, which upstream deleted. Our terminal thread-deleted subscription failure (terminalSnapshotReason) never reaches the item stream, so it cannot go through the batch reducer. Cache removal is now shared between that path and the reducer path via removeCachedThread.

Excluded

  • tasks/todo.md — the upstream author's scratch checklist.

Follow-up (belongs to fork/changes, not this layer)

fork/changes adds reloadFromServer and the result.kind === "reload-required" branch on top of setThread, which this import removes. Rebasing fork/changes onto this layer will conflict there (deliberately — it must not be resolved by dropping the branch). The intended re-expression: have the reducer report the reload-required index, commit state up to it, run reloadFromServer(), then re-enter applyItems with the remaining items — with reloadFromServer itself calling applyItems([{ kind: "snapshot", snapshot: fresh.value }]) instead of the deleted setThread.

Risks worth knowing

  • Live state is now coalesced up to 16 ms (~1 frame). Under TestClock, a batch smaller than 64 items only flushes when the clock advances; upstream's harness pins eventBatchSize: 1 so existing tests keep their per-item assertions.
  • applyItems snapshots state / awaitingCompletion at batch start and writes them back at the end, so a concurrent setDisconnected / setStreamError from the supervisor fiber can be clobbered. The race is pre-existing, but the window widens from per-event to ~16 ms.

Validation

  • vp test run packages/client-runtime/src/state/{threads-sync,threadReducer,threads-atoms}.test.ts — 52 passed
  • vp run -F @t3tools/client-runtime -F @t3tools/web test — 210 files / 1874 tests passed
  • vp check — 0 errors
  • vp run -F @t3tools/client-runtime -F @t3tools/contracts -F @t3tools/web -F @t3tools/mobile typecheck — clean

Workspace-wide typecheck is not meaningful locally on this layer: this worktree's node_modules was installed from fork/changes (@anthropic-ai/claude-agent-sdk@^0.3.220) while fork/candidates pins ^0.3.170, which produces unrelated ClaudeAdapter type errors in apps/server. Fork CI installs from this branch's own lockfile, so it is the authority there. This change touches only packages/client-runtime/src/state/ and the candidate registry.

Note: the agent ship-gate tooling (.githooks/, scripts/agent-pre-push.mjs, pnpm pr:ready) lives in fork/changes and does not exist on fork/candidates, so the equivalent checks above were run by hand.

Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
@patroza
patrozaforce-pushed the import/upstream-pr-5344 branch from 6ca97da to c391f93CompareAugust 5, 2026 07:10
@patroza
patroza merged commit 307f3f8 into fork/candidatesAug 5, 2026
8 checks passed
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
patroza added a commit that referenced this pull request Aug 5, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
omegent-appBot pushed a commit that referenced this pull request Aug 6, 2026
… (#328)
Imported from pingdotgg#5344 at source SHA
783fd02 (commits b623dc2 + 783fd02
squashed into one provenance commit).
Imported behavior:
- `reduceThreadStreamItems`, a pure reducer that folds a batch of thread
stream items into one state and one persistable snapshot.
- `Stream.groupedWithin(64, 16ms)` on the live subscription so a burst of
thread events publishes the `SubscriptionRef` once instead of per event,
and web/mobile stop rebuilding large thread views per streamed event.
- `eventBatchSize` on `EnvironmentThreadStateOptions`, plus the upstream
regression tests for ordered single-publication bursts and for persisting
a settled snapshot when a batch ends with a non-persistable turn start.
Local adaptations:
- Kept our `httpSnapshotLoadAttempted` guard around the HTTP snapshot
fallback; the call now goes through `applyItems([...])`.
- Restored `setDeleted` (removed upstream) for the terminal
`thread-deleted` subscription failure, which never reaches the item
stream and so cannot go through the batch reducer. Cache removal is
shared with the reducer path via `removeCachedThread`.
Excluded:
- `tasks/todo.md`, the author's scratch checklist.
Follow-up (fork/changes, not this layer): our `reload-required` branch and
`reloadFromServer` are built on the deleted `setThread`, so rebasing
fork/changes onto this layer must re-express them against the reducer
(split the batch at the reload point, then re-enter `applyItems` with the
remainder).
Co-authored-by: T3 Code PR Stack <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza