ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

ci(fork): run PR checks when a PR is retargeted or marked ready - #359

Merged
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget
Aug 6, 2026
Merged

ci(fork): run PR checks when a PR is retargeted or marked ready#359
patroza merged 1 commit into
fork/devfrom
fork-dev/ci-on-retarget

Conversation

@omegent-app

Copy link
Copy Markdown

Fixes the cause of #357 sitting on four required checks
that could never report.

What happened

pull_request defaults to the activity types opened, synchronize, reopened. #357's timeline:

EventActivity typeResult
force-pushed while base was fork/discordsynchronizefiltered#348 removed the overlay bases from this workflow's branches list
base changed fork/discordfork/deveditednot a default type
marked ready for reviewready_for_reviewnot a default type

So the PR never emitted a watched event while sitting on a watched base. Zero fork-ci runs existed
for its head SHA, the four required checks stayed Expected — Waiting for status to be reported, and
auto-merge waited on something that had no way to arrive. Toggling draft/ready and re-enabling
auto-merge could not help, because none of those are trigger types either.

Change

List the activity types explicitly and add both missing ones:

types: [opened, synchronize, reopened, ready_for_review, edited]

edited also fires for title and body edits, which happen constantly here and must not spend a
full CI run including a macOS runner. github.event.changes.base is populated only when the base
actually changed, so each job skips an edit that did not move the base.

Unblocking #357 itself

Closed and reopened it — reopenedis a default type, so it fires against the current base
without adding a commit to the branch. Checks are running there now.

Scope

I checked every open PR on fork/dev: only #357 was affected. The others were based on
fork/changes, which is still in the branches list, so their pushes did produce runs. This was
specifically a PR that had been sitting on an overlay base when those bases were removed — a
transitional hazard from the drain, but one worth closing since a required check that can never
report is indistinguishable from a hung CI system.

Co-authored by @patroza

opened by Patrick Roza in chat thread Discord · Discord · T3

#357 sat on four required checks that could never report. It was opened against
fork/discord, force-pushed, then retargeted to fork/dev and marked ready — and
none of those produced a run.
The default pull_request activity set is opened, synchronize and reopened. The
force-push was a synchronize, but the base was still fork/discord, which #348
removed from this workflow's branch list, so it was filtered out. Retargeting
fires "edited", and marking ready fires "ready_for_review"; neither is in the
default set. The PR therefore never emitted a watched event while sitting on a
watched base, and auto-merge waited on checks that had no way to arrive.
List the activity types explicitly and add both missing ones.
"edited" also fires for title and body edits, which happen constantly and must
not spend a full CI run including a macOS runner. github.event.changes.base is
populated only when the base actually changed, so each job skips an edit that
did not move the base.
Unblocking the PR itself needed a close and reopen: "reopened" is in the default
set, so it fires against the current base without adding a commit.
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@patroza
patroza enabled auto-merge (squash) August 6, 2026 08:55
@patroza
patroza merged commit ace285b into fork/devAug 6, 2026
5 checks passed
patroza added a commit that referenced this pull request Aug 6, 2026
Reverts the `edited` half of
[#359](#359). **My change, my
bug** — and it is a merge-gate bypass, so it should go in ahead of the
other open PRs.
## What I got wrong
#359 added `edited` to the `pull_request` activity types so retargeting
a PR would run CI, with a
job-level `if` guard skipping edits that did not move the base. I
reasoned the guard would keep the
cost down. It does — but a **skipped job still publishes a check run**,
GitHub counts a skipped
required check as **satisfied**, and the skipped run **supersedes** the
real one.
So editing the title or body of a PR whose checks had *failed* replaces
those failures with skipped
runs and leaves it mergeable.
Observed live on #364 — I edited the body, and:
```
Check skipping
Mobile Native Static Analysis skipping
Release Smoke skipping
Test skipping
```
with `mergeable: MERGEABLE`, `mergeStateStatus: CLEAN`. Every required
check satisfied by a run that
executed nothing.
## Change
Drop `edited` and the four job guards. Keep `ready_for_review`, which is
what actually fixed the case
#359 was opened for: #357 had been retargeted and then **marked ready**,
and nothing fired.
## What this gives up
Retargeting without a push no longer triggers CI. That is rarer now that
overlays are gone and
everything targets `fork/dev`, and it is recoverable — close and reopen
fires `reopened`, which is
watched. That is how #357 was unblocked in the first place.
A gap that needs a deliberate action to work around beats a bypass that
needs a title edit to
trigger.
Co-authored by [@patroza](https://github.com/patroza)
opened by [Patrick Roza](https://discord.com/users/95218063095377920) in
chat thread **Discord** ·
[Discord](https://discord.com/channels/1083767712431480922/1534783738322485399/1534783738322485399)
· [T3](https://t3vm/?thread=584a9ad3-243e-4308-8a13-49acdd758b17)
Co-authored-by: omegent-app[bot] <306514130+omegent-app[bot]@users.noreply.github.com>
Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@patroza