fix(acp): keep Grok prompt-complete transcript under CI load by patroza · Pull Request #431 · patroza/t3code

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

patroza · 2026-08-29T08:15:42Z

Summary

Post-merge Fork CI on fork/dev after #430 failed two related Grok ACP races:

retains turn transcript when sendTurn is interrupted after prompt success — turns.length was 0. The mock writes the first content.deltabefore_x.ai/session/prompt_complete. Interrupting on that delta plus a few cooperative yields leaves promptRpcSucceeded false under CI load, and the ensuring path drops the transcript. Wait for turn.completed before interrupting.
completes a Grok turn from xAI prompt completion when the prompt RPC hangs — expected 'hello from mock', got 'hello from '. drainEvents only waited on the in-memory event-queue barrier. prompt_complete can settle while the next agent_message_chunk is still in the stdout pipe. Pump the live Node reader and Effect scheduler until a cycle sees an empty queue, then snapshot.

Test plan

vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts (37 passed)
Cursor + Kimi + XAiAcpExtension adapter tests passed
Fork CI Test job green on this SHA

The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.

prompt_complete can settle while the next agent_message_chunk is still in the pipe. A single event-queue barrier misses it under CI load.

test(grok): wait for prompt success before interrupting sendTurn
29f1490
The mock emits the first content chunk before prompt_complete. Interrupting on that delta under CI load drops the transcript because promptRpcSucceeded is still false. Wait for turn.completed instead.