Uh oh!
There was an error while loading. Please reload this page.
WIP - Configurable Paths - #152
Conversation
EvanLovely
commented
Nov 2, 2017
I've got a commit on this branch that cleans up the config setting so diffs should make much more sense now. |
EvanLovely
commented
Nov 2, 2017
I could see using - self::$options["patternSourceDir"] =- isset(self::$options["patternSourceDir"])- ? self::$options["sourceDir"] . DIRECTORY_SEPARATOR . self::cleanDir(self::$options["patternSourceDir"])- : self::$options["sourceDir"] . DIRECTORY_SEPARATOR . "_patterns";+ self::$options["patternSourceDir"] =+ self::getOption('paths.source.patterns')+ ? self::$options["baseDir"] . self::cleanDir(self::getOption("paths.source.patterns"))+ : self::$options["sourceDir"] . DIRECTORY_SEPARATOR . "_patterns"; |
sghoweri
commented
Nov 2, 2017
Oh wait a sec @EvanLovely are you just doing what I think you're doing here? Cleaning up the crappy whitespace with literally zero code changes otherwise? If so, can we merge this down to develop (yay clean diffs) so we can point any subsequent PRs at that easier to follow base? Or maybe a separate PR so this can act as an umbrella ticket? shrug |
Intended to fix#35 to bring in configurable paths besides just pointing towards source directory. This needs to be backwards compatible as well.