Skip to content

replace @ with ~ in urls - #157

Merged
ylebre merged 5 commits into
feature/user-subdomainsfrom
feature/tilde-usernames
May 30, 2025
Merged

replace @ with ~ in urls#157
ylebre merged 5 commits into
feature/user-subdomainsfrom
feature/tilde-usernames

Conversation

@ylebre

Copy link
Copy Markdown
Member

No description provided.

@Potherca

Copy link
Copy Markdown
Member

@ylebre Is this still relevant, or can it be closed in favor of #184 ?

@ylebre

Copy link
Copy Markdown
MemberAuthor

The idea still stands - @ is not a valid character in a URL and should be replaced with the tilde. #184 does not resolve that, unless we go all in on the 'username.nextcloud';

@ylebre
ylebreforce-pushed the feature/tilde-usernames branch from 85c715f to 3100599CompareMay 26, 2025 09:09
@ylebre
ylebre changed the base branch from main to feature/user-subdomainsMay 26, 2025 09:09
@ylebre

Copy link
Copy Markdown
MemberAuthor

I've updated/rebased the PR to feature/user-subdomains so we can pick it up from there once the subdomains change lands.

@ylebre
ylebre marked this pull request as draft May 26, 2025 09:11
@ylebre
ylebre marked this pull request as ready for review May 26, 2025 12:49
@ylebreylebre mentioned this pull request May 26, 2025
@ylebre
ylebreforce-pushed the feature/tilde-usernames branch from 367dc71 to cfadbdbCompareMay 30, 2025 09:23
@ylebre
ylebre merged commit 8d4f04d into feature/user-subdomainsMay 30, 2025
@ylebre
ylebre deleted the feature/tilde-usernames branch May 30, 2025 09:26
@PothercaPotherca added this to the v0.10.0 milestone Oct 13, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ylebre@Potherca