nightshift/tests: add coverage for 3 units - #11
Open
perandre wants to merge 1 commit into
Open
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\nFound coverage gaps and added tests for 3 units.\n\n## Tests added\n-
app/lib/__tests__/aggregator.test.ts— 9 tests coveringprocessActivities()andgetDaySummary(): hour bucketing, spanning events, email deduplication, calendar notification filtering, source separation, empty-day handling\n-app/lib/ai/__tests__/parse.test.ts— 9 tests coveringparseSuggestions(): valid JSON, markdown-wrapped responses, hour rounding, confidence defaults, truncated response salvaging, unique IDs, internalNote parsing, empty sourceActivities\n-app/lib/ai/__tests__/preprocess.test.ts— 7 tests coveringpreprocessActivities(): flattening/sorting, calendar minute calculation, spanning entry deduplication, invite email filtering, source-specific title generation, activity deduplication, empty input\n\nAlso addedvitest.config.tswith path alias resolution for the@/*import pattern.\n\n## Verification\n- All 25 tests pass locally\n- Build succeeds with no errors