Skip to content

[FEATURE] add column settings to logs table - #698

Open
jgbernalp wants to merge 1 commit into
mainfrom
feat/logstable-column-settings
Open

[FEATURE] add column settings to logs table#698
jgbernalp wants to merge 1 commit into
mainfrom
feat/logstable-column-settings

Conversation

@jgbernalp

@jgbernalpjgbernalp commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds column settings for the logs table

related to:
perses/perses#3786
perses/perses#4143

Screenshots

Screen.Recording.2026-06-24.at.15.20.39.mov

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@jgbernalp
jgbernalp requested review from a team and AntoineThebaud as code ownersJune 24, 2026 13:32
@jgbernalp
jgbernalp requested review from Gladorme and removed request for a teamJune 24, 2026 13:32
@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch 2 times, most recently from da3add0 to 2209870CompareJune 24, 2026 13:39
@jgbernalp
jgbernalp requested a review from zhujeJune 24, 2026 13:39
@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch from 2209870 to 43f5696CompareJune 24, 2026 13:43
@Gladorme

Copy link
Copy Markdown
Member

I am wondering if it could re-use column settings from Table plugin? Or too much thing we do not need in LogTable?

@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch 2 times, most recently from 1005c87 to 0be660bCompareJune 26, 2026 10:08
@jgbernalp

jgbernalp commented Jun 26, 2026

Copy link
Copy Markdown
ContributorAuthor

I am wondering if it could re-use column settings from Table plugin? Or too much thing we do not need in LogTable?

I wanted to add a simple feature. I think in the future this logs table should be replaced by the table plugin. We just need to add support for log queries there.

@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch from 0be660b to b0935ebCompareJune 26, 2026 10:12
@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch 4 times, most recently from 026a591 to 399ad7fCompareJuly 10, 2026 11:19
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp
jgbernalpforce-pushed the feat/logstable-column-settings branch from 399ad7f to f0b667aCompareJuly 10, 2026 11:47
onUpdate={handleUpdateColumn}
onMoveUp={handleMoveUp}
onMoveDown={handleMoveDown}
renderNameField={(col, index, onUpdate) => (

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why passing name field, width and wrap as props? 🤔

</Box>
);

if (!allowWrap) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it working for you?
When I disable wrapping and hover on it, I don't see tooltip 🤔

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I saw LogRow code just after, log line is hardcoded with case, we may want to add the same logic to it

{ansiHtml ? (
<LogText
variant="body2"
allowWrap={column.allowWrap ?? allowWrap}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref to prev comment, we don't have tooltip if allowWrap disabled

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jgbernalp@Gladorme