Uh oh!
There was an error while loading. Please reload this page.
Add is_clear method - #79
Conversation
jrraymond
commented
Jul 2, 2022
Thanks. Can you please add some tests for this function? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Thank for the review! Very important to keep thing names consistent in documentation. I indeed picked up "element" by just looking at the iterator methods. I'll fix that. A question: the docs use both "enabled/disabled" and "set/unset" for value = 1/0. You seem to prefer "set/unset", and I'll follow this preference, but I prefer "enabled/disabled" since "set" can also mean a set of values. |
nicopap
commented
Jul 3, 2022
I'm very happy with the second pass on the docs. Although, in insight, I'm a bit skittish about both updating the doc on |
jrraymond
commented
Jul 3, 2022
"enabled/disabled" is ok. Using "bit" instead of element is more important. Don't worry about updating the doc on |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jrraymond
left a comment
There was a problem hiding this comment.
Thanks! As a final step, could you please add some test for is_clear()?
nicopap
commented
Jul 4, 2022
Thank you for the directions and the merge! Was the doc example code enough test? |
When using this library, the intent of checking if all elements in a bitset are disabled is better expressed with a specialized method. I doubt it's particularly more performant than
bitset.count_ones(..) == 0, but when reading code usingFixedBitSet, it's easier to understand what is going on with abitset.is_clear()than abitset.count_ones(..) == 0.I also added docs so that it's less easy to get confused as to what "empty" means (I think the confusion was raised multiple times in the past)