Conversation
src/ngtcp2/ was the final remnant of the vendored ngtcp2 examples. Its five
helpers all belong to the HTTP/3 backend and nothing else, so they move into
anyhttp::http3 next to the other shared QUIC/HTTP/3 building blocks, keeping
the provenance and MIT note in a banner comment:
network.h -> sockaddr_union, Address
util.{h,cc} -> timestamp(), straddr(), format_hex()
shared.{h,cc}-> msghdr_get_local_addr(), set_port()
Two of them are simplified rather than transplanted verbatim: format_hex()
collapses from three iterator-constrained overloads plus a 512-byte lookup
table to one format_hex(const uint8_t*, size_t), as both call sites only ever
pass cid.data/cid.datalen, and straddr() reports through loge() and builds its
result with std::format instead of std::cerr and manual appends.
h3_session.cpp is already in anyhttp::http3 and calls them unqualified;
h3_server.cpp and h3_client.cpp pull the names in with using declarations
alongside the existing log_headers/make_nv ones. to_ngtcp2_address() becomes
to_address(), the type it produces no longer being ngtcp2::Address.
The vendored sources drop out of src/CMakeLists.txt (the *.cpp glob covers
h3_common.cpp) and out of the coverage ignore regex. src/ngtcp2/README.md also
noted that the devcontainer installs the upstream examples as osslclient and
osslserver; that note moves to HTTP3.md, where it already pointed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…d remove the corresponding file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.