Close websocket with 1011 on internal error (1006 is a client-only code) - #112
Merged
Merged
Conversation
samsamoa
commented
Mar 18, 2023
ContributorAuthor
Related wsproto issue: python-hyper/wsproto#182 |
pgjones
commented
Jul 8, 2023
Owner
Looks good thanks. I'll take a look at wsproto shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.rfc-editor.org/rfc/rfc6455.html ->
This issue is exacerbated by what may be a bug in wsproto, where a 1006 code is turned into a 1000 (success) code.