Uh oh!
There was an error while loading. Please reload this page.
ENH : Add Angrist-Krueger QOB (1980 Census) dataset - #2
Conversation
DARHWOLF
left a comment
There was a problem hiding this comment.
Thanks, may I request the following changes:-
- please move this outside the
realdirectory. This dataset will have its own directory. - please include the License file from https://github.com/pgmpy/example_datasets/blob/main/real/LICENSE
- please add a readme for this dataset's directory.
- please add this dataset to the repository's main readme.
Dijo-404
commented
Mar 4, 2026
Sure working on it. |
c3d088b to
eb77a20CompareThere was a problem hiding this comment.
Pull request overview
Adds the Angrist–Krueger Quarter-of-Birth (1980 Census) dataset to this example_datasets repository so it can be referenced/validated by pgmpy (per pgmpy#2737).
Changes:
- Introduces a new
angrist-krueger-qob/dataset folder with dataset documentation and CC0 license text. - Adds the dataset listing entry to the repository root
README.md.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
angrist-krueger-qob/README.md | Adds dataset description, citation, and file listing. |
angrist-krueger-qob/LICENSE | Adds CC0 1.0 Universal license text for the dataset folder. |
README.md | Adds a new entry pointing to the Angrist–Krueger QOB dataset folder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eb77a20 to
098b54eCompareDijo-404
commented
Mar 4, 2026
Accidentally closed it, having some merge conflicts, working on it |
Fixed the issues and added the requested changes. Let me know if everything looks good now |
333f67f to
977aa9cCompare
Dijo-404
left a comment
There was a problem hiding this comment.
I have done the requested changes
Uh oh!
There was an error while loading. Please reload this page.
DARHWOLF
commented
Mar 6, 2026
I'm not sure why there is a need to force-push? |
Dijo-404
commented
Mar 6, 2026
Every time I sync my fork and pull the latest updates to the branch, I get a merge conflict. That's why I had to rebase and force-push |
c8f157b to
f78b09cComparef78b09c to
8b6b15aCompare# Conflicts: # README.md
example_datasetsrepository.pgmpyPR to allow for verification of the dataset and its associated tags.Related PR:pgmpy/pgmpy#2737