Skip to content

add a new dataset from NSLM - #5

Merged
ankurankan merged 9 commits into
pgmpy:mainfrom
stephanielees:feature/add_new_data_NSLM
Mar 12, 2026
Merged

add a new dataset from NSLM#5
ankurankan merged 9 commits into
pgmpy:mainfrom
stephanielees:feature/add_new_data_NSLM

Conversation

@stephanielees

Copy link
Copy Markdown
Contributor

The data from the National Study of Learning Mindsets is one of the latest datasets wanted to be added to pgmpy. The larger list of new datasets is here

@DARHWOLFDARHWOLF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the dataset. May I request the following:

  • Since this is a simulated dataset, this should not be in the real directory.
  • Please move this outside the real directory.
  • There needs to be a licence file added to in this module
  • I suppose the readme of this module could have column-descriptions of the dataset and references.
  • Please add this dataset to the readme of the repository

-- I see a line spacing after each row, should these be removed?

@stephanielees

Copy link
Copy Markdown
ContributorAuthor

I'm not sure I can find the license file for the specific dataset... The dataset is part of the R package grf, and that package is under the GPL-3.0 license. Can we use that license? @DARHWOLF

@DARHWOLF

Copy link
Copy Markdown
Member

This file needs to be prersent in the module
https://github.com/pgmpy/example_datasets/blob/main/real/LICENSE

@DARHWOLFDARHWOLF mentioned this pull request Mar 4, 2026
1 task

@DARHWOLFDARHWOLF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when AA approves.

Comment threadnslm/README.md
@@ -0,0 +1,21 @@
The dataset is from the National Study of Learning Mindsets and is mentioned in the paper titled "Estimating Treatment Effects with Causal Forests: An Application" by Susan Athey and Stefan Wager.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to add a citation reference to the paper. Or perhaps in the extension PR.

Comment threadREADME.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be in alphabetical order?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I have sorted all the dataset names in alphabetical order just now.

@stephanielees
stephanielees marked this pull request as draft March 6, 2026 02:25
@stephanielees
stephanielees marked this pull request as ready for review March 6, 2026 02:25
@stephanielees

Copy link
Copy Markdown
ContributorAuthor

LGTM when AA approves.

@ankurankan Hi Ankur, can you please review this PR?

@ankurankan
ankurankan merged commit ed45410 into pgmpy:mainMar 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@stephanielees@DARHWOLF@ankurankan