feat: add unix socket discovery and connection support by XYenon · Pull Request #6 · pgplex/pgtui

XYenon · 2026-03-31T04:22:25Z

No description provided.

Copilot

Pull request overview

Adds Unix socket discovery to the database instance auto-discovery flow and standardizes how connection targets are displayed (including Unix socket targets), enabling users to discover/connect to local PostgreSQL instances that expose only a socket.

Changes:

Added a Unix socket scanner that searches common socket directories and integrates results into overall discovery.
Introduced DisplayTarget() / UsesUnixSocket() helpers on connection/discovery models and updated UI/error rendering to use them.
Centralized “discovered instance → connection config” logic into a dedicated builder and updated connection flows to use it.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/ui/components/connection_dialog.go	Render discovered targets using the new unified display helper.
internal/models/connection.go	Add Unix-socket detection and unified target formatting for display.
internal/db/discovery/unix_socket.go	Implement Unix socket directory scanning and availability probing.
internal/db/discovery/unix_socket_test.go	Add tests for Unix socket discovery and config defaults.
internal/db/discovery/discovery.go	Include Unix socket scanning in overall discovery and improve sorting stability.
internal/db/discovery/config.go	Centralize default connection config creation for discovered instances.
internal/app/delegates/connection.go	Improve connection error target display via `DisplayTarget()`.
internal/app/app.go	Use centralized discovery config builder when connecting to discovered instances.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Amp-Thread-ID: https://ampcode.com/threads/T-019d41f5-fe46-7119-afb7-73548b6954ed Co-authored-by: Amp <amp@ampcode.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

…words BuildConnectionConfig returned GetEnvironmentConfig() verbatim for the environment source, carrying Name="Environment" and the PGPASSWORD/ .pgpass password into the connection pipeline. - Clear Name on the env path so the connection ID and history entry fall back to ConnectionLabel() (e.g. user@host:port/db), matching the other discovered sources instead of producing duplicate "Environment" history entries and a fixed connection ID. - Clear Password on both the env and .pgpass paths. pgx still resolves the credential via libpq defaults (PGPASSWORD env, ~/.pgpass), so connections authenticate unchanged, but the password no longer gets persisted to the OS keyring on success.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Strip leading/trailing spaces from PGHOST/PGPORT/PGDATABASE/PGUSER/ PGSSLMODE so connection strings stay valid. Leave PGPASSWORD untrimmed.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Bound listenPostgresSocket Accept with a deadline and a select timeout so a missed dial cannot hang tests. Stop filling Password in buildPgPassConfig; libpq reads ~/.pgpass and we intentionally keep secrets out of the keyring.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

tianzhou

LGTM. Thanks for the contribution.

tianzhou requested a review from Copilot July 11, 2026 05:05

Copilotstarted reviewing on behalf of tianzhou July 11, 2026 05:05 View session

CopilotAI reviewed Jul 11, 2026
View reviewed changes

Comment threadinternal/db/discovery/unix_socket.go
Comment threadinternal/db/discovery/config.go Outdated
Comment threadinternal/db/discovery/unix_socket.go

tianzhou requested a review from Copilot July 11, 2026 12:15

Copilotstarted reviewing on behalf of tianzhou July 11, 2026 12:16 View session

CopilotAI reviewed Jul 11, 2026
View reviewed changes

Comment threadinternal/db/discovery/config.go
Comment threadinternal/db/discovery/unix_socket.go Outdated

XYenonand others added 4 commits July 13, 2026 15:04

feat: add unix socket discovery and connection support
6e4caa5
Amp-Thread-ID: https://ampcode.com/threads/T-019d41f5-fe46-7119-afb7-73548b6954ed Co-authored-by: Amp <amp@ampcode.com>

fix(discovery): address unix socket review feedback
ecdc571

refactor(discovery): simplify unix socket changes
09d6ff4

fix(discovery): use current module imports
e363a66

XYenon force-pushed the feat/unix-socket-scan branch from 343528a to e363a66Compare July 13, 2026 07:13

tianzhou requested a review from Copilot July 13, 2026 07:27

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 07:28 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

Comment threadinternal/db/discovery/discovery.go Outdated
Comment threadinternal/db/discovery/unix_socket.go

fix(discovery): use stable keys for dedupe
5a65edf

tianzhou requested a review from Copilot July 13, 2026 08:14

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 08:15 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

Comment threadinternal/db/discovery/discovery.go
Comment threadinternal/db/discovery/unix_socket_test.go

fix(discovery): prefer credential sources when deduping
9fdd613

tianzhou requested a review from Copilot July 13, 2026 11:31

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 11:32 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

Comment threadinternal/db/discovery/discovery.go
Comment threadinternal/db/discovery/config.go
Comment threadinternal/models/connection.go Outdated

XYenon added 3 commits July 13, 2026 20:05

fix(discovery): align priority and endpoint formatting
3bc50a7

refactor(discovery): simplify port and config helpers
664d95e

tianzhou requested a review from Copilot July 13, 2026 12:57

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 12:57 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

Comment threadinternal/db/discovery/environment.go

fix(discovery): trim whitespace from libpq env vars
d6e649d
Strip leading/trailing spaces from PGHOST/PGPORT/PGDATABASE/PGUSER/ PGSSLMODE so connection strings stay valid. Leave PGPASSWORD untrimmed.

tianzhou requested a review from Copilot July 13, 2026 14:56

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 14:57 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

Comment threadinternal/db/discovery/unix_socket_test.go
Comment threadinternal/db/discovery/config.go

tianzhou requested a review from Copilot July 13, 2026 15:13

Copilotstarted reviewing on behalf of tianzhou July 13, 2026 15:13 View session

CopilotAI reviewed Jul 13, 2026
View reviewed changes

tianzhou approved these changes Jul 13, 2026
View reviewed changes

tianzhou merged commit 0534649 into pgplex:mainJul 13, 2026
6 checks passed

XYenon deleted the feat/unix-socket-scan branch July 13, 2026 15:37

Uh oh!

Conversation

XYenon commented Mar 31, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

tianzhou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants