Uh oh!
There was an error while loading. Please reload this page.
ci: unbreak the iOS and Android test-app builds [FEPLAT-5048] - #53
Merged
Conversation
Both jobs fail on master today, so every pull request opens with red checks and a real regression would not stand out. - **iOS**: the build step resolved the simulator UDID for a hardcoded `iPhone 16` and exited 1 when the grep found nothing, which is what happens now that the runner image dropped that device. The job only builds and never boots the app, so it takes `-destination 'generic/platform=iOS Simulator'` and stops depending on the image's simulator list. - **Android**: `JetifyTransform` ran out of heap on `hermes-android-0.73.5-debug.aar`. Jetifier rewrites every class of every AAR, and React Native 0.73 and its dependencies are AndroidX already, so the conversion is off. Heap also goes 2g to 4g, since the same job passed on 16 GB runners until recently and one OOM cancels the whole matrix.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe iOS CI workflow now uses a generic simulator destination. The example Android project increases the Gradle heap limit and disables Jetifier with explanatory comments. ChangesiOS CI configuration
Android build configuration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ilan-phantom
approved these changes
Aug 12, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both jobs fail on
mastertoday, so every pull request opens with red checks and a real regression would not stand out. PR #52 is the case in point: four red Android checks and two red iOS checks, none of them caused by that diff.iPhone 16and exited 1 when the grep found nothing, which is what happens now that the runner image dropped that device. The job only builds and never boots the app, so it takes-destination 'generic/platform=iOS Simulator'and stops depending on the image's simulator list.JetifyTransformran out of heap onhermes-android-0.73.5-debug.aar. Jetifier rewrites every class of every AAR, and React Native 0.73 and its dependencies are AndroidX already, so the conversion is now off. Heap also goes 2g to 4g, because one OOM cancels the whole four-job matrix.The checks on this PR are the verification: a dependency that genuinely still needed jetifier would fail here with unresolved
android.support.*classes, and the fallback would be to keepenableJetifier=trueand rely on the larger heap alone.Two follow-ups deliberately left out:
gradle/gradle-build-action@v2is deprecated in favour ofactions/setup-gradle, and #51 pins action SHAs across every workflow, so it will touchios-ci.ymltoo.Summary by CodeRabbit