Conversation
EddyVerbruggen
added a commit
to Telerik-Verified-Plugins/PushNotification
that referenced
this pull request
Jun 29, 2014
|
Manually partly merged this PR, thanks! |
midas19910709
added a commit
to midas19910709/phonegap-plugin-push
that referenced
this pull request
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a notification is activated but the plugin is not active, an intent is created to activate the main activity:
https://github.com/phonegap-build/PushPlugin/blob/master/src/android/com/plugin/gcm/PushHandlerActivity.java#L60-L62
Since the default
android:launchMode( android docs ) causes a new instance of the activity to be created, a new webview is created even if the app is already running in background.The simple solution is to change the launchMode so that a single instance is used.
This pull request adds documentation to the README.md and the plugin.xml so the developers are aware of this, since cordova does not allow adding the attribute automatically on plugin install.