Skip to content

Added clobbers for PushNotification - #87

Merged
bobeasterday merged 3 commits into
phonegap-build:masterfrom
mkuklis:master
Oct 28, 2013
Merged

bobeasterday merged 3 commits into
phonegap-build:masterfrom
mkuklis:master

Conversation

@mkuklis

@mkuklis mkuklis commented Oct 12, 2013

Copy link
Copy Markdown

No description provided.

@chriswiggins

Copy link
Copy Markdown

window.plugins is deprecated as of Cordova 3.0 so we shouldn't even be including that in the JS. Otherwise I agree with the commits :-)

@mkuklis

mkuklis commented Oct 15, 2013

Copy link
Copy Markdown
Author

@chriswiggins cool I haven't touched window.plugins in this commit. I just wanted to add clobbers so I can use it properly in Cordova >= 3.0

bobeasterday added a commit that referenced this pull request Oct 28, 2013
Added clobbers for PushNotification
@bobeasterday
bobeasterday merged commit 23a130b into phonegap-build:master Oct 28, 2013
@zhjuncai

Copy link
Copy Markdown

I'm using phonegap 3.3 and also have the same error "Uncaught RererenceError: Module is not defined at line 66

can anyone tell how to fix this?

@rgksugan

Copy link
Copy Markdown

Still having the same issue

EddyVerbruggen added a commit that referenced this pull request Jul 1, 2014
improved module condition - issue #87
gaguirre pushed a commit to gaguirre/phonegap-plugin-push that referenced this pull request Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants