Uh oh!
There was an error while loading. Please reload this page.
PHP 8.3 + Mago QA toolchain + Result test coverage - #39
Open
simon-mundy wants to merge 3 commits into
Open
Conversation
… coverage php-db/phpdb 0.6.x added getQueryResult() to Driver\ResultInterface, which Sqlite already satisfies for free via the shared core Pdo\Result class (no sqlite-owned Result class exists). Ports the core's exhaustive Pdo\Result unit test suite to cover it, matching the coverage mysql/pgsql carry for their own Result classes. Also replaces laminas-coding-standard/phpstan with the shared php-db/phpdb-qa-tools Mago toolchain, mirroring phpdb-qa-analysis-sql: mago.toml extending the shared base, the qa-tools phpunit.xml.dist template, mago-based composer scripts, and the reusable CI workflow. Pre-existing lint/analyzer findings in untouched code are captured in lint-baseline.toml/analyzer-baseline.toml rather than fixed here.
tyrsson
requested changes
Aug 26, 2026
tyrsson
left a comment
Member
There was a problem hiding this comment.
Base config needs updated to align => in array's. mago supports it. There is also a few missing docblock types reported. If those are supposed to be part of the next set of changes disregard this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pdo\Resultclass, including the newgetQueryResult()method sqlite already gets for free (no sqlite-owned Result class to touch).git-blame-ignore-revssogit blamestays usefulPre-existing lint/analyzer findings in untouched code are baselined, not fixed here — that's a separate job.
Test plan
composer test(97 unit tests)composer test-integration(18 tests)mago format --check,mago lint,mago analyzeall clean