Skip to content

Add Parameter & Return Types (versions 3 of the library) - #24

Merged
Jean85 merged 1 commit into
php-fig:masterfrom
navarr:return-types
Oct 29, 2021
Merged

Add Parameter & Return Types (versions 3 of the library)#24
Jean85 merged 1 commit into
php-fig:masterfrom
navarr:return-types

Conversation

@navarr

@navarrnavarr commented Jul 4, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Please see php-fig/fig-standards#1252 for an explanation

Crell
Crell reviewed Jul 14, 2021
View reviewed changes
Comment threadsrc/CacheInterface.php
@navarr

navarr commented Aug 25, 2021

Copy link
Copy Markdown
ContributorAuthor

I've force-pushed. This rebases the iterable document types to be the first commit, so that all proposed releases include them.

@navarrnavarr mentioned this pull request Aug 25, 2021
Merged
@navarr
Add return types
19a4d7c
This is a breaking change since implementations without return types are considered to be "widening" them, which is not allowed in PHP.
Implementations that implement v3, however, are also implementing v1 and v2 as of PHP 7.4, so such implementations can use a require statement of `^1|^2|^3`. Usage libraries also can use a require statement of `^1|^2|^3`
@navarr

navarr commented Aug 27, 2021

Copy link
Copy Markdown
ContributorAuthor

I've force pushed. This rebase updates the commit messages and the composer.json files to align with recent edits to the meta document

@navarrnavarr changed the title Add Return Types (v2 of library)Add Parameter & Return Types (versions 2 and 3 of library)Aug 27, 2021
@Geolim4

Geolim4 commented Sep 2, 2021

Copy link
Copy Markdown

Can you mention me once this MR is merged please ?

I need to prepare the next major update of Phpfastcache, thanks 👼🏻

@ADmadADmad mentioned this pull request Sep 8, 2021
Closed
@Crell

Crell commented Sep 17, 2021

Copy link
Copy Markdown

Everything looks good here, I think. Just some issues on the spec PR itself.

@Geolim4

Geolim4 commented Oct 5, 2021•
edited
Loading

Copy link
Copy Markdown

Hello @Crell, not wanting to be pressing or anything but this seems to take much longer than it took for the PSR-6 to make the PHP-8 type upgrade ?

Thanks again :)

@Crell

Crell commented Oct 6, 2021

Copy link
Copy Markdown

Someone needs to call the vote on it. Paging @navarr or @Jean85...

@Jean85

Jean85 commented Oct 6, 2021

Copy link
Copy Markdown
Member

I'm not ok with having this in a single PR before calling a vote. We need two separate PR/branches, to have a clear separation of the proposed tags.

@Geolim4

Geolim4 commented Oct 6, 2021

Copy link
Copy Markdown

I'm not ok with having this in a single PR before calling a vote. We need two separate PR/branches, to have a clear separation of the proposed tags.

Can the concerned people make the changes and proceed to the vote ? This "simple" upgrade for PHP 8 is during for almost five months now.

It's in the FIG's interest to be proactive and do the good things to improve interoperability for PHP community.

Thank you @Jean85 🙏🏻

@Jean85Jean85 mentioned this pull request Oct 6, 2021
Merged
@Jean85
Jean85 changed the base branch from master to param-typesOctober 6, 2021 11:05
@Jean85Jean85 changed the title Add Parameter & Return Types (versions 2 and 3 of library)Add Parameter & Return Types (versions 3 of the library)Oct 6, 2021
@Jean85

Jean85 commented Oct 6, 2021

Copy link
Copy Markdown
Member

I've done it myself, by splitting this into #25 and changing the base here.

I'll try to call a vote ASAP.

This was referenced Oct 6, 2021
Open
Closed
Closed
@dragoonis

dragoonis commented Oct 6, 2021

Copy link
Copy Markdown
Member

As long as things are addressed, as per
#13 (comment)
then we are good here.

@Jean85Jean85 mentioned this pull request Oct 6, 2021
Closed
@navarr

navarr commented Oct 6, 2021

Copy link
Copy Markdown
ContributorAuthor

@Jean85 Why are the PRs split? Do we need two separate votes for these changes?

@Jean85

Jean85 commented Oct 6, 2021

Copy link
Copy Markdown
Member

@Jean85 Why are the PRs split? Do we need two separate votes for these changes?

No but we will need two different releases, so we need to make the CC able to review those separately. And us to tag separately, too.

@Jean85
Jean85 deleted the branch php-fig:masterOctober 29, 2021 13:22
@Jean85Jean85 closed this Oct 29, 2021
@Jean85

Jean85 commented Oct 29, 2021

Copy link
Copy Markdown
Member

Closed by mistake (stupid automations!)

Vote has passed: https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y
PSR changes are merged: php-fig/fig-standards#1252

Releasing this as 3.0.0 now.

@Jean85Jean85 reopened this Oct 29, 2021
@Jean85
Jean85 changed the base branch from param-types to masterOctober 29, 2021 13:25
@Jean85
Jean85 merged commit 764e0b3 into php-fig:masterOct 29, 2021
@Geolim4

Geolim4 commented Oct 29, 2021

Copy link
Copy Markdown

Yes, finally 🥳 🎉

Thanks for that and sorry for pushing again and again, I will have some work this weekend :D

@Geolim4

Geolim4 commented Oct 29, 2021

Copy link
Copy Markdown

@Jean85 can you create the Github releases after pushing tags too ? Thank you !

@Jean85

Jean85 commented Oct 29, 2021

Copy link
Copy Markdown
Member

@Geolim4 done!

@phil-davisphil-davis mentioned this pull request Dec 4, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CrellCrellCrell left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@navarr@Geolim4@Crell@Jean85@dragoonis