Skip to content

PSR-2 compliance - #25

Closed
tuupola wants to merge 4 commits into
php-http:masterfrom
tuupola:psr2-fixes
Closed

PSR-2 compliance#25
tuupola wants to merge 4 commits into
php-http:masterfrom
tuupola:psr2-fixes

Conversation

@tuupola

@tuupolatuupola commented Feb 11, 2017

Copy link
Copy Markdown
Contributor
QA
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Related ticketsmentioned in #24
LicenseMIT

What's in this PR?

Makes code PSR-2 compliant with the exception of relaxing the PSR1.Methods.CamelCapsMethodName for spec files. Additionally uses short array syntax in tests as discussed in #24. Lastly adds PHPCS to vendor and enables running it via $ composer phpcs.

I know this is three things in one PR but I feel these are closely related and the last one is easy remove if it is unwanted.

PSR1.Methods.CamelCapsMethodName is ignored for tests.
See discussion in #24.
@sagikazarmark

Copy link
Copy Markdown
Member

Thanks for the contribution, although I have a few problems with it:

  • such changes should be discussed on the boilerplate repo first
  • the spec files are kind of specially treated: they follow the PHPSpec style first, then PSR-1/2: so short array syntax, line breaking apply, camel case, method visibility for example do not.

@tuupola

Copy link
Copy Markdown
ContributorAuthor

Ok. I though the camel case rule was the only one which should be relaxed.

@tuupolatuupola closed this Feb 11, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tuupola@sagikazarmark